fix(dns) explicitly disable dns in env when disabled in injector #3077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KUMA_RUNTIME_KUBERNETES_INJECTOR_BUILTIN_DNS_ENABLED was not working because we were simply not setting any env var if it was set. As kuma-dp starts the builtin dns by default we need to explictly disable it by setting the env var on injection. Signed-off-by: Charly Molter <charly.molter@konghq.com>
Codecov Report
@@ Coverage Diff @@
## master #3077 +/- ##
==========================================
+ Coverage 52.19% 52.23% +0.03%
==========================================
Files 919 919
Lines 53116 53120 +4
==========================================
+ Hits 27725 27746 +21
+ Misses 23184 23168 -16
+ Partials 2207 2206 -1
Continue to review full report at Codecov.
|
nickolaev
approved these changes
Nov 3, 2021
michaelbeaumont
approved these changes
Nov 3, 2021
mergify bot
pushed a commit
that referenced
this pull request
Nov 4, 2021
KUMA_RUNTIME_KUBERNETES_INJECTOR_BUILTIN_DNS_ENABLED was not working because we were simply not setting any env var if it was set. As kuma-dp starts the builtin dns by default we need to explictly disable it by setting the env var on injection. Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit 2d08e3f)
lahabana
added a commit
that referenced
this pull request
Nov 4, 2021
…) (#3085) KUMA_RUNTIME_KUBERNETES_INJECTOR_BUILTIN_DNS_ENABLED was not working because we were simply not setting any env var if it was set. As kuma-dp starts the builtin dns by default we need to explictly disable it by setting the env var on injection. Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit 2d08e3f) Co-authored-by: Charly Molter <charly.molter@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KUMA_RUNTIME_KUBERNETES_INJECTOR_BUILTIN_DNS_ENABLED was not working
because we were simply not setting any env var if it was set.
As kuma-dp starts the builtin dns by default we need to explictly disable it by setting the env var on injection.
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.