feat(disableipv6) don't add v6 in DNS when v6 is disabled #3089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there's no port forward for v6 we shouldn't add v6 ips in the config Signed-off-by: Charly Molter <charly.molter@konghq.com>
jakubdyszkiewicz
approved these changes
Nov 4, 2021
mergify bot
pushed a commit
that referenced
this pull request
Nov 4, 2021
If there's no port forward for v6 we shouldn't add v6 ips in the config Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit 1f507fd) # Conflicts: # pkg/xds/generator/testdata/tracing/zipkin.envoy-config-https.golden.yaml
lahabana
added a commit
that referenced
this pull request
Nov 4, 2021
If there's no port forward for v6 we shouldn't add v6 ips in the config Signed-off-by: Charly Molter <charly.molter@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's no port forward for v6 we shouldn't add v6 ips in the config
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.