fix(kuma-cp): add cp selector to global sync service #3579
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CP selector in Global Remote Sync service was missing.
It was ok, because in Global CP was the only component that was running with
app.kubernetes.io/name: kuma
, so it was always selected, but we should select the control plane explicitly in case a new component will arrive in the future next to Global CP.Issues resolved
No reported issues.
Documentation
No docs.
Testing
Backwards compatibility
UPGRADE.md
with any steps users will need to takewhen upgrading.
backport-to-stable
label if the code is backwards compatible. Otherwise, list breaking changes.