Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): add cp selector to global sync service #3579

Merged
merged 1 commit into from Dec 21, 2021

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

CP selector in Global Remote Sync service was missing.
It was ok, because in Global CP was the only component that was running with app.kubernetes.io/name: kuma, so it was always selected, but we should select the control plane explicitly in case a new component will arrive in the future next to Global CP.

Issues resolved

No reported issues.

Documentation

No docs.

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take
    when upgrading.
  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2021

Codecov Report

Merging #3579 (12e2e7c) into master (dfb2ade) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3579   +/-   ##
=======================================
  Coverage   51.57%   51.58%           
=======================================
  Files         918      918           
  Lines       55568    55568           
=======================================
+ Hits        28657    28662    +5     
+ Misses      24625    24623    -2     
+ Partials     2286     2283    -3     
Impacted Files Coverage Δ
pkg/plugins/leader/postgres/leader_elector.go 97.87% <0.00%> (-2.13%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 85.86% <0.00%> (-1.09%) ⬇️
api/observability/v1/mads.pb.go 35.56% <0.00%> (+1.03%) ⬆️
pkg/mads/v1/client/client.go 43.75% <0.00%> (+2.50%) ⬆️
pkg/xds/cache/once/once.go 100.00% <0.00%> (+5.00%) ⬆️
pkg/xds/cache/once/cache.go 87.17% <0.00%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfb2ade...12e2e7c. Read the comment docs.

@jakubdyszkiewicz jakubdyszkiewicz merged commit a8271c3 into master Dec 21, 2021
@jakubdyszkiewicz jakubdyszkiewicz deleted the fix/selector-kds-service branch December 21, 2021 09:07
mergify bot pushed a commit that referenced this pull request Dec 21, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit a8271c3)
mergify bot added a commit that referenced this pull request Dec 21, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit a8271c3)

Co-authored-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants