feat(kumactl): add --api-timeout flag #3723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #3723 +/- ##
=======================================
Coverage 50.85% 50.85%
=======================================
Files 925 925
Lines 56789 56790 +1
=======================================
+ Hits 28878 28880 +2
+ Misses 25619 25616 -3
- Partials 2292 2294 +2
Continue to review full report at Codecov.
|
tests were flaky because we were modifying a global variable. Extracted this global var in a configuration parameter as it may be useful anyway Signed-off-by: Charly Molter <charly.molter@konghq.com> Actually do api-timeout for the whole kumactl Signed-off-by: Charly Molter <charly.molter@konghq.com>
lahabana
changed the title
jakubdyszkiewicz
approved these changes
Jan 20, 2022
Signed-off-by: Charly Molter <charly.molter@konghq.com>
Signed-off-by: Charly Molter <charly.molter@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tests were flaky because we were modifying a global variable.
Extracted this global var in a configuration parameter as it may be
useful anyway.
Documentation
[ ] Link to the website documentation PRTesting
Backwards compatibility
[ ] UpdateUPGRADE.mdwith any steps users will need to take when upgrading.[ ] Addbackport-to-stablelabel if the code follows our backporting policy