Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(e2e): simplify e2e tests by build a config file #3727

Merged
merged 2 commits into from Jan 24, 2022

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Jan 18, 2022

Summary

Currently a lot of parameters are scattered around the codebase as global variables.
This aims to reduce some of the global parameters.

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • [ ] Update UPGRADE.md with any steps users will need to take when upgrading.
  • [ ] Add backport-to-stable label if the code follows our backporting policy

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2022

Codecov Report

Merging #3727 (af2a2f4) into master (45a6d5a) will increase coverage by 0.10%.
The diff coverage is 3.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3727      +/-   ##
==========================================
+ Coverage   50.89%   50.99%   +0.10%     
==========================================
  Files         924      925       +1     
  Lines       56960    56853     -107     
==========================================
+ Hits        28987    28994       +7     
+ Misses      25689    25570     -119     
- Partials     2284     2289       +5     
Impacted Files Coverage Δ
test/e2e/auth/auth_universal.go 0.00% <0.00%> (ø)
test/e2e/auth/dp/dp_auth_universal.go 0.00% <0.00%> (ø)
...atibility/cp_compatibility_kubernetes_multizone.go 0.00% <0.00%> (ø)
...st/e2e/compatibility/dp_compatibility_universal.go 0.00% <0.00%> (ø)
test/e2e/deploy/kuma_deploy_global_zone.go 0.00% <0.00%> (ø)
test/e2e/deploy/kuma_deploy_universal.go 0.00% <0.00%> (ø)
.../deploy/kuma_deploy_universal_transparent_proxy.go 0.00% <0.00%> (ø)
...2e/externalservices/externalservices_hostheader.go 0.00% <0.00%> (ø)
...2e/externalservices/externalservices_kubernetes.go 0.00% <0.00%> (ø)
...alservices/externalservices_multizone_universal.go 0.00% <0.00%> (ø)
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45a6d5a...af2a2f4. Read the comment docs.

@lahabana lahabana force-pushed the e2eTestNew branch 3 times, most recently from 17d2d3e to 0916f7e Compare January 21, 2022 13:10
@lahabana lahabana marked this pull request as ready for review January 21, 2022 13:11
@lahabana lahabana requested a review from a team as a code owner January 21, 2022 13:11
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a nice cleanup

test/framework/config.go Show resolved Hide resolved
pkg/config/display.go Show resolved Hide resolved
Currently a lot of parameters are scattered around the codebase as global variables.
This aims to reduce some of the global parameters.

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana
Copy link
Contributor Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jan 24, 2022

update

✅ Branch has been successfully updated

@lahabana lahabana merged commit 9bf9fbb into kumahq:master Jan 24, 2022
@lahabana lahabana deleted the e2eTestNew branch March 29, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants