-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kuma-cp): protocol check should be case insensitive #4248
Conversation
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
do we also treat |
In some places, we check lower cases by using https://github.com/kumahq/kuma/blob/master/pkg/core/resources/apis/mesh/dataplane_helpers.go#L26. Maybe the best option will be to lowercase that at |
I'm ok with lower-casing in inbound converter |
Decision from triage:
|
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #4248 +/- ##
==========================================
- Coverage 55.65% 55.60% -0.06%
==========================================
Files 935 935
Lines 56347 56347
==========================================
- Hits 31361 31331 -30
- Misses 22504 22523 +19
- Partials 2482 2493 +11
Continue to review full report at Codecov.
|
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
3efb54f
to
0d3b351
Compare
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Summary
When protocol label is defined with uppercased value
TCP
deployment of gateway fails because it's different thanTCP
.We can discuss in issue if we want this way or maybe make it different way.
Full changelog
Issues resolved
Fix #4247
Documentation
Testing
Backwards compatibility
UPGRADE.md
with any steps users will need to take when upgrading.backport-to-stable
label if the code follows our backporting policy