feat(gateway): cp annotations from gateway to svc #4327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4327 +/- ##
==========================================
- Coverage 55.75% 55.70% -0.05%
==========================================
Files 935 935
Lines 56434 56437 +3
==========================================
- Hits 31462 31439 -23
- Misses 22498 22527 +29
+ Partials 2474 2471 -3
Continue to review full report at Codecov.
|
|
Test failure looks unrelated? |
|
@johnharris85 What do you think about just adding a single |
michaelbeaumont
approved these changes
May 23, 2022
lahabana
approved these changes
May 23, 2022
michaelbeaumont
force-pushed
the
meshgateway-annotations
branch
from
6837a95
to
a2323eb
Compare
|
/golden_files |
|
Arg obviously my tool is broken with forks :( |
lahabana
approved these changes
May 24, 2022
Signed-off-by: John Harris <john@johnharris.io>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont
force-pushed
the
meshgateway-annotations
branch
from
a2323eb
to
faa8b0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Many cloud providers use annotations on service objects to control behavior with their auto-provisioned load balancers. This PR adds a feature that will copy all annotations specified on the
MeshGatewayInstanceobject to the generated service.In #4075 there was some discussion about how to implement this, and a suggestion that maybe we go down the route of creating a CRD that would allow full customization of the generated service. This makes sense in future, however the 90% use case is solved by just enabling a user to specify annotations. This PR's implementation covers that use case for users who are currently experiencing issues while not adding / altering any CRDs / APIs, and is easy to deprecate when we decide on a 'better' solution.
Will add docs if folks are fine with this implementation.
Issues resolved
Partially fix #4075
Documentation
Testing
- [ ] Manual testing on UniversalBackwards compatibility
- [ ] UpdateUPGRADE.mdwith any steps users will need to take when upgrading.- [ ] Addbackport-to-stablelabel if the code follows our backporting policy