Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(*): changed map to list in Dataplane object #4388

Merged
merged 2 commits into from Jun 1, 2022
Merged

fix(*): changed map to list in Dataplane object #4388

merged 2 commits into from Jun 1, 2022

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented May 30, 2022 •
edited

Summary

Map is not a proper model for CRD, changed metrics configuration from Map to List which is the recommended way on k8s.

Full changelog

  • [Changed map to list]
  • [Adjust tests to the new model]
  • [Removed test that based on goldenfile because of order and there is test which check the same thing but with proper equals]

Issues resolved

Fix #4381

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take when upgrading.
  • Add backport-to-stable label if the code follows our backporting policy

@lukidzi
fix(*): changed map to list in Dataplane object
af0a9ae 
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi requested a review from a team as a code owner May 30, 2022 17:15
lahabana
lahabana reviewed May 31, 2022
View reviewed changes
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's no validation on name being unique in the list. That's the one drawback of moving from map to list...

bartsmykla
bartsmykla approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukidzi
fix(*): added validator of unique entries
da43383 
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi
Copy link
Contributor Author

lukidzi commented May 31, 2022

Added validation if the list contains unique values

@lukidzi lukidzi merged commit 03e6be5 into master Jun 1, 2022
@lukidzi lukidzi deleted the fix/metrics-list branch June 1, 2022 11:18
mergify bot pushed a commit that referenced this pull request Jun 1, 2022
@lukidzi @mergify
fix(*): changed map to list in Dataplane object (#4388)
5f66d66 
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
(cherry picked from commit 03e6be5)
@mergify mergify bot mentioned this pull request Jun 1, 2022
Merged
mergify bot added a commit that referenced this pull request Jun 1, 2022
@mergify @lukidzi
fix(*): changed map to list in Dataplane object (backport #4388) (#4406)
f147947 
fix(*): changed map to list in Dataplane object (#4388)

Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
(cherry picked from commit 03e6be5)

Co-authored-by: Łukasz Dziedziak <lukidzi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana approved these changes

@bartsmykla bartsmykla bartsmykla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix map in application metrics in dataplane resource
3 participants
@lukidzi @lahabana @bartsmykla