Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid -<arch> in version of the binaries #4510

Merged
merged 3 commits into from
Jun 30, 2022
Merged

Conversation

lahabana
Copy link
Contributor

This would cause multiple problems and is superflous.

Signed-off-by: Charly Molter charly.molter@konghq.com

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take when upgrading.
  • Add backport-to-stable label if the code follows our backporting policy

@lahabana lahabana marked this pull request as ready for review June 27, 2022 15:56
@lahabana lahabana requested a review from a team as a code owner June 27, 2022 15:56
This would cause multiple problems and is superflous.

Fix kumahq#4505

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022

Codecov Report

Merging #4510 (cad93bc) into master (80b560b) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4510      +/-   ##
==========================================
+ Coverage   55.43%   55.50%   +0.06%     
==========================================
  Files         947      947              
  Lines       58168    58168              
==========================================
+ Hits        32247    32287      +40     
+ Misses      23365    23343      -22     
+ Partials     2556     2538      -18     
Impacted Files Coverage Δ
api/observability/v1/mads.pb.go 35.56% <0.00%> (+1.03%) ⬆️
pkg/plugins/resources/postgres/store.go 76.79% <0.00%> (+2.10%) ⬆️
pkg/mads/v1/client/client.go 43.75% <0.00%> (+2.50%) ⬆️
pkg/defaults/components.go 85.71% <0.00%> (+3.57%) ⬆️
...s/authn/api-server/tokens/admin_token_bootstrap.go 86.00% <0.00%> (+4.00%) ⬆️
pkg/core/tokens/signing_key_manager.go 90.00% <0.00%> (+5.00%) ⬆️
pkg/core/secrets/manager/global_manager.go 45.45% <0.00%> (+6.06%) ⬆️
pkg/core/runtime/component/component.go 93.54% <0.00%> (+9.67%) ⬆️
pkg/metrics/store/counter.go 85.45% <0.00%> (+10.90%) ⬆️
pkg/clusterid/creator.go 86.66% <0.00%> (+13.33%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80b560b...cad93bc. Read the comment docs.

@lahabana lahabana enabled auto-merge (squash) June 28, 2022 07:29
…tests)

- add flag to enable the arch tag if needed

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana merged commit c4e0fe0 into kumahq:master Jun 30, 2022
mergify bot pushed a commit that referenced this pull request Jun 30, 2022
This would cause multiple problems and is superflous.

Fix #4505

Signed-off-by: Charly Molter <charly.molter@konghq.com>
(cherry picked from commit c4e0fe0)
mergify bot added a commit that referenced this pull request Jul 4, 2022
fix: avoid `-<arch>` in version of the binaries (#4510)

This would cause multiple problems and is superflous.

Fix #4505

Signed-off-by: Charly Molter <charly.molter@konghq.com>
(cherry picked from commit c4e0fe0)

Co-authored-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana deleted the fixArch branch March 29, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants