Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(.github): always run Helm version update #4605

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Conversation

michaelbeaumont
Copy link
Contributor

Summary

Otherwise we still need to do the Chart.yaml appVersion bump manually.

@michaelbeaumont michaelbeaumont force-pushed the fix/helm_workflow branch 2 times, most recently from 86bdc61 to c13f985 Compare July 15, 2022 08:59
@michaelbeaumont michaelbeaumont marked this pull request as ready for review July 15, 2022 08:59
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner July 15, 2022 08:59
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont merged commit 0fbb4eb into master Jul 18, 2022
@michaelbeaumont michaelbeaumont deleted the fix/helm_workflow branch July 18, 2022 10:36
@lobkovilya
Copy link
Contributor

@Mergifyio backport release-1.7 release-1.6

mergify bot pushed a commit that referenced this pull request Oct 7, 2022
* refactor(tools): fix --update-version so it can always run
* fix(.github): always run Helm version update

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
(cherry picked from commit 0fbb4eb)
@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2022

backport release-1.7 release-1.6

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 7, 2022
* refactor(tools): fix --update-version so it can always run
* fix(.github): always run Helm version update

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
(cherry picked from commit 0fbb4eb)
lobkovilya pushed a commit that referenced this pull request Oct 7, 2022
fix(.github): always run Helm version update  (#4605)

* refactor(tools): fix --update-version so it can always run
* fix(.github): always run Helm version update

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
(cherry picked from commit 0fbb4eb)

Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
lobkovilya pushed a commit that referenced this pull request Oct 7, 2022
fix(.github): always run Helm version update  (#4605)

* refactor(tools): fix --update-version so it can always run
* fix(.github): always run Helm version update

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
(cherry picked from commit 0fbb4eb)

Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants