Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(helm): always run Helm version update (#4604)" #4609

Merged

Conversation

michaelbeaumont
Copy link
Contributor

Summary

This should have been in #4603 😞
This reverts commit 6bd83ed.

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner July 15, 2022 13:26
This reverts commit 6bd83ed.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #4609 (0147eaf) into release-1.7 (c040a33) will increase coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-1.7    #4609   +/-   ##
============================================
  Coverage        55.68%   55.68%           
============================================
  Files              943      943           
  Lines            57867    57867           
============================================
+ Hits             32221    32226    +5     
+ Misses           23107    23104    -3     
+ Partials          2539     2537    -2     
Impacted Files Coverage Δ
pkg/kds/client/sink.go 59.45% <0.00%> (-8.11%) ⬇️
pkg/plugins/resources/postgres/store.go 76.37% <0.00%> (-0.43%) ⬇️
pkg/core/secrets/manager/global_manager.go 42.42% <0.00%> (ø)
pkg/mads/server/server.go 82.72% <0.00%> (+1.81%) ⬆️
pkg/core/resources/manager/cache.go 88.31% <0.00%> (+2.59%) ⬆️
pkg/core/tokens/default_signing_key.go 77.77% <0.00%> (+2.77%) ⬆️
pkg/core/tokens/signing_key_manager.go 90.00% <0.00%> (+5.00%) ⬆️
pkg/defaults/mesh.go 78.57% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c040a33...0147eaf. Read the comment docs.

@michaelbeaumont michaelbeaumont enabled auto-merge (squash) July 15, 2022 13:58
@michaelbeaumont michaelbeaumont merged commit 46f8e13 into kumahq:release-1.7 Jul 15, 2022
@michaelbeaumont michaelbeaumont deleted the fix/revert_helm_change branch July 15, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants