Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp) Gateway mode in Dataplane #503

Merged
merged 3 commits into from
Dec 20, 2019

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

Added gateway mode to the Dataplane. As far as I tested it works with policies (tags from gateway field are being used).

K8S support is coming in the next PR.

@jakubdyszkiewicz jakubdyszkiewicz requested review from yskopets and a team December 19, 2019 12:39
Comment on lines 50 to 51
// Gateway describes a service that ingress should not be proxied ex. API
// Gateways
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't understand this comment

api/mesh/v1alpha1/dataplane.proto Outdated Show resolved Hide resolved
api/mesh/v1alpha1/dataplane.proto Outdated Show resolved Hide resolved
api/mesh/v1alpha1/dataplane.proto Outdated Show resolved Hide resolved
api/mesh/v1alpha1/dataplane_helpers_test.go Outdated Show resolved Hide resolved
api/mesh/v1alpha1/dataplane_helpers_test.go Outdated Show resolved Hide resolved
pkg/core/resources/apis/mesh/dataplane_validator.go Outdated Show resolved Hide resolved
pkg/core/resources/apis/mesh/dataplane_validator.go Outdated Show resolved Hide resolved
Copy link
Contributor

@yskopets yskopets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update CHANGELOG.md as part of this PR

Copy link
Contributor

@yskopets yskopets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to update/create a test for GetDataplaneIdentity() function (pkg/sds/auth/common/identity.go):

  • previously, the identity of a Dataplane was inferred from inbound listeners
  • now, the identity might come from gateway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants