-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kuma-cp) Gateway mode in Dataplane #503
Conversation
api/mesh/v1alpha1/dataplane.proto
Outdated
// Gateway describes a service that ingress should not be proxied ex. API | ||
// Gateways |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I don't understand this comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update CHANGELOG.md
as part of this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to update/create a test for GetDataplaneIdentity()
function (pkg/sds/auth/common/identity.go
):
- previously, the identity of a
Dataplane
was inferred frominbound
listeners - now, the identity might come from
gateway
760eaf5
to
998c511
Compare
998c511
to
79f5e3f
Compare
Summary
Added gateway mode to the Dataplane. As far as I tested it works with policies (tags from
gateway
field are being used).K8S support is coming in the next PR.