Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(kuma-cp): resource manager wrapper #5057

Merged
merged 1 commit into from
Sep 26, 2022
Merged

chore(kuma-cp): resource manager wrapper #5057

merged 1 commit into from
Sep 26, 2022

Conversation

jakubdyszkiewicz
Copy link
Contributor

Adds the ability to wrap customizable resource manager with another manager.

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@jakubdyszkiewicz
chore(kuma-cp): resource manager wrapper
e8f1659 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner September 26, 2022 08:19
@jakubdyszkiewicz jakubdyszkiewicz enabled auto-merge (squash) September 26, 2022 08:29
@jakubdyszkiewicz jakubdyszkiewicz merged commit 6ccee97 into kumahq:master Sep 26, 2022
@jakubdyszkiewicz jakubdyszkiewicz deleted the chore/res-manager-wrapper branch September 26, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartsmykla bartsmykla bartsmykla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakubdyszkiewicz @bartsmykla