chore: fetch Envoy from Github artifacts #5329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
bartsmykla
reviewed
Nov 16, 2022
bartsmykla
reviewed
Nov 16, 2022
bartsmykla
approved these changes
Nov 16, 2022
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
lobkovilya
approved these changes
Nov 16, 2022
Closed
|
@Mergifyio backport release-2.0 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 8, 2023
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com> (cherry picked from commit 8198e76) # Conflicts: # mk/envoy.mk # tools/releases/distros.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I uploaded Envoy binaries here https://github.com/kumahq/envoy-builds/releases/tag/v1.22.1 following the convention specified here https://github.com/425devon/envoy-builds/blob/cd16b3e388ee8fa167b17b44c421226484d779f6/.github/workflows/ci_amd.yaml#L249-L259
Binaries in tars in
envoy-buildsare simpleenvoy-alpine,envoy-darwinetc. I think it's useful to still use the version in Envoy binary name in Kuma build directory. This way if code changes the version and you still have old binary, we will fetch the new one. Either way, in the package for end user, it has justenvoy.I simplified
distros.shto just use binaries fetched using Make.fix #5269
Checklist prior to review
syscall.Mkfifohave equivalent implementation on the other OS --UPGRADE.md? --> Changelog:entry here or add aci/label to run fewer/more tests?