Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(changelog): fix changelog script for dependabot rollups #5363

Merged
merged 2 commits into from Nov 29, 2022
Merged

ci(changelog): fix changelog script for dependabot rollups #5363

merged 2 commits into from Nov 29, 2022

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Nov 23, 2022 •
edited

Use a regexp instead of random splits as it's more robust Fix badly implemented min/max functions

Now the changelog look like:

* chore(deps): bump github.com/onsi/gomega from 1.23.0 to 1.24.1 [#5275](https://github.com/kumahq/kuma/pull/5275) [#5313](https://github.com/kumahq/kuma/pull/5313) @dependabot
* chore(deps): bump github.com/prometheus/client_golang from 1.13.0 to 1.14.0 [#5274](https://github.com/kumahq/kuma/pull/5274) [#5323](https://github.com/kumahq/kuma/pull/5323) @dependabot
* chore(deps): bump github.com/prometheus/prometheus from 0.39.1 to 0.40.2 [#5320](https://github.com/kumahq/kuma/pull/5320) [#5353](https://github.com/kumahq/kuma/pull/5353) @dependabot

And changes like: * chore(deps): update to emicklei/go-restful/v3 v3.10.1 and remove /tokens [#5324](https://github.com/kumahq/kuma/pull/5324) @dependabot do not cause issues anymore

Signed-off-by: Charly Molter charly.molter@konghq.com

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lahabana lahabana added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Nov 23, 2022
@lahabana lahabana requested a review from slonka November 23, 2022 10:46
@lahabana lahabana requested a review from a team as a code owner November 23, 2022 10:46
@slonka
Copy link
Contributor

slonka commented Nov 23, 2022

nice! can you just check that you can summarise whole history like --from-tag=0.0.1 (or --from-commit=initial-commit)?

@lahabana
Copy link
Contributor Author

nice! can you just check that you can summarise whole history like --from-tag=0.0.1 (or --from-commit=initial-commit)?

Good idea I'll try this (I'm scared though :) )

@lahabana
Copy link
Contributor Author

Here's the full changelog: https://gist.github.com/lahabana/f0238964cfd8a3222c96185d050c9fb8 :)

@lahabana
Copy link
Contributor Author

The sorting of semver is not ideal though e.g: chore(deps): bump github.com/spf13/viper from 1.10.0 to 1.9.0 #3382 #4177 #4396 #4994 #5273 @dependabot

Gotta see what we can do

@lahabana
ci(changelog): fix changelog script for dependabot rollups
cf4ea50 
Use a regexp instead of random splits as it's more robust
Fix badly implemented min/max functions

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana
fix version range
19511d8 
Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana
Copy link
Contributor Author

Fix my issues and updated the full changelog on the linked Gist

@lahabana lahabana enabled auto-merge (squash) November 29, 2022 10:26
@lahabana lahabana merged commit 3055b1e into kumahq:master Nov 29, 2022
@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
@lahabana lahabana deleted the fixChangelog branch May 2, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slonka slonka slonka approved these changes

@lukidzi lukidzi lukidzi approved these changes

Assignees
No one assigned
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lahabana @slonka @lukidzi