Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(dp/cp/config): remove EnableLocalhostInboundClusters op… #6219

Conversation

bartsmykla
Copy link
Contributor

@bartsmykla bartsmykla commented Mar 7, 2023

…tion (#6214)"

This reverts commit 1e8033b.

Reverting till #5335 is fixed (Envoy 1.25)

Changelog: skip

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

…tion (kumahq#6214)"

This reverts commit 1e8033b.

Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla requested review from a team, slonka and lobkovilya and removed request for a team March 7, 2023 12:22
@bartsmykla bartsmykla merged commit a67fdf1 into kumahq:master Mar 7, 2023
@bartsmykla bartsmykla deleted the chore/revert-remove-enablelocalhostinboundlusters-config-option branch March 7, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants