-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(k8s): add a configuration option to list allowed service accounts #6505
Merged
slonka
merged 7 commits into
kumahq:release-2.2
from
slonka:feat-add-allowed-service-accounts-list
Apr 11, 2023
Merged
feat(k8s): add a configuration option to list allowed service accounts #6505
slonka
merged 7 commits into
kumahq:release-2.2
from
slonka:feat-add-allowed-service-accounts-list
Apr 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for ValidatingAdmissionWebhook Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
slonka
requested review from
a team,
michaelbeaumont,
Automaat and
lukidzi
and removed request for
a team and
michaelbeaumont
April 11, 2023 07:51
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
slonka
commented
Apr 11, 2023
Signed-off-by: slonka <slonka@users.noreply.github.com>
lahabana
approved these changes
Apr 11, 2023
lukidzi
approved these changes
Apr 11, 2023
@lahabana should I backport this to all active releases? It doesn't panic / crash or hang but it does spin consuming a lot of CPU. |
I'd do without |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a configuration option to list allowed service accounts for
ValidatingAdmissionWebhook
. This is needed forstorageversionmigrator
that creates modification request (that actually don't modify anything from the user perspective "...gets the object, then writes it back to the API server without modification.") .fixes #6504
Tested locally with
KUMA_RUNTIME_KUBERNETES_ALLOWED_SERVICE_ACCOUNTS=system:serviceaccount:kube-system:default
and it works,storageversionmigrator
stopped spinning and got:Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here or add aci/
label to run fewer/more tests?