Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker/kumactl): add entrypoint to kumactl img (backport #6593) #6594

Merged
merged 1 commit into from Apr 24, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 24, 2023

This is an automatic backport of pull request #6593 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Without specifying entrypoint inside the Dockerfile, it was
impossible to use the image without having to do it explicitly
during the container start

It was impossible to do:
```sh
docker run kumahq/kuma:2.2.0 kumactl version
```
and you had to explicitly specify entrypoint
```sh
docker run --entrypoint /usr/bin/kumactl kumahq/kuma:2.2.0 version
```

Signed-off-by: Bart Smykla <bartek@smykla.com>
(cherry picked from commit fe153f0)
@mergify mergify bot requested review from a team, slonka and Automaat and removed request for a team April 24, 2023 07:46
@mergify mergify bot merged commit 64aee6c into release-2.2 Apr 24, 2023
6 checks passed
@mergify mergify bot deleted the mergify/bp/release-2.2/pr-6593 branch April 24, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant