Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dataplane_watchdog): fix outdated comment #7565

Merged

Conversation

nicoche
Copy link
Contributor

@nicoche nicoche commented Aug 22, 2023

I think that they do use Mesh Hash now, cf. lines 178 and 226

@nicoche nicoche requested a review from a team as a code owner August 22, 2023 15:19
@nicoche nicoche requested review from jakubdyszkiewicz and Automaat and removed request for a team August 22, 2023 15:19
@nicoche nicoche force-pushed the fix-comment-dataplane-watchdog branch from 95297e2 to db9637e Compare August 22, 2023 15:22
Signed-off-by: nicoche <78445450+nicoche@users.noreply.github.com>
@nicoche nicoche force-pushed the fix-comment-dataplane-watchdog branch from db9637e to 18af7af Compare August 22, 2023 15:34
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true! thx

@jakubdyszkiewicz jakubdyszkiewicz merged commit 5d5b48b into kumahq:master Aug 23, 2023
5 checks passed
@nicoche nicoche deleted the fix-comment-dataplane-watchdog branch August 23, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants