Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dataplane_watchdog): fix outdated comment #7565

Merged
merged 1 commit into from
Aug 23, 2023
Merged

fix(dataplane_watchdog): fix outdated comment #7565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pkg/xds/sync/dataplane_watchdog.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,8 @@ func (d *DataplaneWatchdog) syncDataplane(ctx context.Context, metadata *core_xd
return result, nil
}

// syncIngress synces state of Ingress Dataplane. Notice that it does not use Mesh Hash yet because Ingress supports many Meshes.
// syncIngress synces state of Ingress Dataplane.
// It uses Mesh Hash to decide if we need to regenerate configuration or not.
func (d *DataplaneWatchdog) syncIngress(ctx context.Context, metadata *core_xds.DataplaneMetadata) (SyncResult, error) {
envoyCtx := &xds_context.Context{
ControlPlane: d.EnvoyCpCtx,
Expand Down Expand Up @@ -206,8 +207,8 @@ func (d *DataplaneWatchdog) syncIngress(ctx context.Context, metadata *core_xds.
return result, nil
}

// syncEgress syncs state of Egress Dataplane. Notice that it does not use
// Mesh Hash yet because Egress supports many Meshes.
// syncEgress syncs state of Egress Dataplane.
// It uses Mesh Hash to decide if we need to regenerate configuration or not.
func (d *DataplaneWatchdog) syncEgress(ctx context.Context, metadata *core_xds.DataplaneMetadata) (SyncResult, error) {
envoyCtx := &xds_context.Context{
ControlPlane: d.EnvoyCpCtx,
Expand Down