Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(k8s): fix VIPs configmap entries with invalid keys for ExternalName services #8168

Merged
merged 12 commits into from Oct 31, 2023
Merged

fix(k8s): fix VIPs configmap entries with invalid keys for ExternalName services #8168

merged 12 commits into from Oct 31, 2023

Conversation

bartsmykla
Copy link
Contributor

Services with the ExternalName type do not allow us to get an IP address, so the generated VIPs config map contains entries with invalid keys, such as 1:. This was hard to debug because we were getting an EOF error during unmarshalling of the VIPs config map.

This commit fixes the issue by ignoring services of that type with appropriate log when it'll happen.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues
    • No relevant issue
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS
    • It won't
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
    • Added unit test
  • Do you need to update UPGRADE.md?
    • There is no need
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)
    • It does

@bartsmykla
fix(k8s): fix VIPs configmap entries with invalid keys for ExternalNa…
7289d75 
…me services

Services with the `ExternalName` type do not allow us to get an
IP address, so the generated VIPs config map contains entries with
invalid keys, such as `1:`. This was hard to debug because we were
getting an EOF error during unmarshalling of the VIPs config map.

This commit fixes the issue by ignoring services of that type with
appropriate log when it'll happen.

Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla requested a review from a team as a code owner October 27, 2023 10:17
jakubdyszkiewicz
jakubdyszkiewicz reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help me understand how this fix relates to invalid VIPs?

service_controller.go is used to annotate services with an ngxing/kong annotation to use ClusterIP instead of PodIP.

@bartsmykla
chore: ignore getting kube hosts for ExternalName
999eb00 
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla
chore: address review remark
eb4b8b1 
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla
chore: address review remarks
00fb82d 
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla
chore: skip adding ExternalName inbounds
4b1e786 
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla
Merge remote-tracking branch 'upstream/master' into fix/ignore-extern…
0421ab1 
…alname-services
@bartsmykla
chore: adjust comment
2267b63 
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla
chore: fix package name
2dd9664 
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla
Merge remote-tracking branch 'upstream/master' into fix/ignore-extern…
f9b6204 
…alname-services
@bartsmykla
chore: address review remarks
a05514f 
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla enabled auto-merge (squash) October 30, 2023 10:52
@bartsmykla
chore: move externalname service check belove serviceless check
6a8c88a 
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla merged commit 23f9001 into kumahq:master Oct 31, 2023
5 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023 •
edited

backporting to release-2.1 with action

backporting to release-2.3 with action
backporting to release-2.4 with action

@kumahq kumahq bot mentioned this pull request Oct 31, 2023
Merged
kumahq bot pushed a commit that referenced this pull request Oct 31, 2023
@bartsmykla @kumahq
fix(k8s): fix VIPs configmap entries with invalid keys for ExternalNa…
b56cd46 
…me services (#8168)

Services with the `ExternalName` type do not allow us to get an
IP address, so the generated VIPs config map contains entries with
invalid keys, such as `1:`. This was hard to debug because we were
getting an EOF error during unmarshalling of the VIPs config map.

This commit fixes the issue by ignoring services of that type with
appropriate log when it'll happen.

Signed-off-by: Bart Smykla <bartek@smykla.com>
kumahq bot pushed a commit that referenced this pull request Oct 31, 2023
@bartsmykla @kumahq
fix(k8s): fix VIPs configmap entries with invalid keys for ExternalNa…
6b73319 
…me services (#8168)

Services with the `ExternalName` type do not allow us to get an
IP address, so the generated VIPs config map contains entries with
invalid keys, such as `1:`. This was hard to debug because we were
getting an EOF error during unmarshalling of the VIPs config map.

This commit fixes the issue by ignoring services of that type with
appropriate log when it'll happen.

Signed-off-by: Bart Smykla <bartek@smykla.com>
@kumahq kumahq bot mentioned this pull request Oct 31, 2023
Merged
@kumahq kumahq bot mentioned this pull request Oct 31, 2023
Merged
kumahq bot pushed a commit that referenced this pull request Oct 31, 2023
@bartsmykla @kumahq
fix(k8s): fix VIPs configmap entries with invalid keys for ExternalNa…
ab53efa 
…me services (#8168)

Services with the `ExternalName` type do not allow us to get an
IP address, so the generated VIPs config map contains entries with
invalid keys, such as `1:`. This was hard to debug because we were
getting an EOF error during unmarshalling of the VIPs config map.

This commit fixes the issue by ignoring services of that type with
appropriate log when it'll happen.

Signed-off-by: Bart Smykla <bartek@smykla.com>
@kumahq kumahq bot mentioned this pull request Oct 31, 2023
Merged
kumahq bot pushed a commit that referenced this pull request Oct 31, 2023
@bartsmykla @kumahq
fix(k8s): fix VIPs configmap entries with invalid keys for ExternalNa…
cb1f61e 
…me services (#8168)

Services with the `ExternalName` type do not allow us to get an
IP address, so the generated VIPs config map contains entries with
invalid keys, such as `1:`. This was hard to debug because we were
getting an EOF error during unmarshalling of the VIPs config map.

This commit fixes the issue by ignoring services of that type with
appropriate log when it'll happen.

Signed-off-by: Bart Smykla <bartek@smykla.com>
kumahq bot pushed a commit that referenced this pull request Oct 31, 2023
@bartsmykla @kumahq
fix(k8s): fix VIPs configmap entries with invalid keys for ExternalNa…
6c859e9 
…me services (#8168)

Services with the `ExternalName` type do not allow us to get an
IP address, so the generated VIPs config map contains entries with
invalid keys, such as `1:`. This was hard to debug because we were
getting an EOF error during unmarshalling of the VIPs config map.

This commit fixes the issue by ignoring services of that type with
appropriate log when it'll happen.

Signed-off-by: Bart Smykla <bartek@smykla.com>
@kumahq kumahq bot mentioned this pull request Oct 31, 2023
Merged
bartsmykla added a commit that referenced this pull request Oct 31, 2023
@kumahq @bartsmykla
fix(k8s): fix VIPs configmap entries with invalid keys for ExternalNa…
94c02a9 
…me services (backport of #8168) (#8198)

fix(k8s): fix VIPs configmap entries with invalid keys for ExternalName services (#8168)

Services with the `ExternalName` type do not allow us to get an
IP address, so the generated VIPs config map contains entries with
invalid keys, such as `1:`. This was hard to debug because we were
getting an EOF error during unmarshalling of the VIPs config map.

This commit fixes the issue by ignoring services of that type with
appropriate log when it'll happen.

Signed-off-by: Bart Smykla <bartek@smykla.com>
Co-authored-by: Bart Smykla <bartek@smykla.com>
bartsmykla added a commit that referenced this pull request Oct 31, 2023
@kumahq @bartsmykla
fix(k8s): fix VIPs configmap entries with invalid keys for ExternalNa…
b6da9d5 
…me services (backport of #8168) (#8196)

fix(k8s): fix VIPs configmap entries with invalid keys for ExternalName services (#8168)

Services with the `ExternalName` type do not allow us to get an
IP address, so the generated VIPs config map contains entries with
invalid keys, such as `1:`. This was hard to debug because we were
getting an EOF error during unmarshalling of the VIPs config map.

This commit fixes the issue by ignoring services of that type with
appropriate log when it'll happen.

Signed-off-by: Bart Smykla <bartek@smykla.com>
Co-authored-by: Bart Smykla <bartek@smykla.com>
bartsmykla added a commit that referenced this pull request Oct 31, 2023
@kumahq @bartsmykla
fix(k8s): fix VIPs configmap entries with invalid keys for ExternalNa…
bf43252 
…me services (backport of #8168) (#8195)

fix(k8s): fix VIPs configmap entries with invalid keys for ExternalName services (#8168)

Services with the `ExternalName` type do not allow us to get an
IP address, so the generated VIPs config map contains entries with
invalid keys, such as `1:`. This was hard to debug because we were
getting an EOF error during unmarshalling of the VIPs config map.

This commit fixes the issue by ignoring services of that type with
appropriate log when it'll happen.

Signed-off-by: Bart Smykla <bartek@smykla.com>
Co-authored-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla deleted the fix/ignore-externalname-services branch October 31, 2023 07:01
bartsmykla pushed a commit that referenced this pull request Oct 31, 2023
@kumahq
fix(k8s): fix VIPs configmap entries with invalid keys for ExternalNa…
e616385 
…me services (backport of #8168) (#8194)

Services with the `ExternalName` type do not allow us to get an
IP address, so the generated VIPs config map contains entries with
invalid keys, such as `1:`. This was hard to debug because we were
getting an EOF error during unmarshalling of the VIPs config map.

This commit fixes the issue by ignoring services of that type with
appropriate log when it'll happen.

Signed-off-by: Bart Smykla <bartek@smykla.com>
bartsmykla pushed a commit that referenced this pull request Oct 31, 2023
@kumahq
fix(k8s): fix VIPs configmap entries with invalid keys for ExternalNa…
6474eab 
…me services (backport of #8168) (#8197)

Services with the `ExternalName` type do not allow us to get an
IP address, so the generated VIPs config map contains entries with
invalid keys, such as `1:`. This was hard to debug because we were
getting an EOF error during unmarshalling of the VIPs config map.

This commit fixes the issue by ignoring services of that type with
appropriate log when it'll happen.

Signed-off-by: Bart Smykla <bartek@smykla.com>
@BrewTestBot BrewTestBot mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana left review comments

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@lobkovilya lobkovilya Awaiting requested review from lobkovilya

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bartsmykla @lahabana @michaelbeaumont @jakubdyszkiewicz