fix(k8s): fix VIPs configmap entries with invalid keys for ExternalName services (backport of #8168) #8196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kumahq[bot]](https://avatars.githubusercontent.com/u/67433617?s=60&v=4){kind=small}
…me services (#8168) Services with the `ExternalName` type do not allow us to get an IP address, so the generated VIPs config map contains entries with invalid keys, such as `1:`. This was hard to debug because we were getting an EOF error during unmarshalling of the VIPs config map. This commit fixes the issue by ignoring services of that type with appropriate log when it'll happen. Signed-off-by: Bart Smykla <bartek@smykla.com>
bartsmykla
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic cherry-pick of #8168 for branch release-2.3
Generated by action
cherry-picked commit 23f9001