Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kuma-cp) remove interface from dataplane model #832

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

removes old interface field that used to be used to describe port + serviceport + address.
This supposed to be removed in 0.5.0.

Documentation

already removed from docs some time ago.

fix #786

@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team June 15, 2020 10:53
Copy link
Contributor

@nickolaev nickolaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickolaev
Copy link
Contributor

Depend on #831

@jakubdyszkiewicz jakubdyszkiewicz changed the base branch from feat/outbound-tags to master June 17, 2020 12:04
@jakubdyszkiewicz jakubdyszkiewicz merged commit 0912911 into master Jun 18, 2020
@jakubdyszkiewicz jakubdyszkiewicz deleted the chore/remove-interface-from-dp branch June 18, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove legacy interface DP inbound/outbound format
2 participants