feat(kuma-cp) add ServiceAddress to dataplane Inbound #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
added 2 commits
July 9, 2020 19:05
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
…t, ParseIP Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
|
Will it work in Kubernetes with transparent proxy mode? If not, we need somehow show that this property should be used only on Universal, maybe we can add validation. |
added 2 commits
July 10, 2020 11:53
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
| } | ||
| return text, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
Awesome, thank's for cleaning it up.
| if inbound.ServicePort == 0 || inbound.ServicePort == inbound.Port { | ||
| result.AddViolationAt(validators.RootedAt("serviceAddress"), `serviceAddress and servicePort has to differ from inboundIP and Port`) | ||
| } | ||
| } |
There was a problem hiding this comment.
can you add tests for those new cases?
added 2 commits
July 14, 2020 09:33
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
jakubdyszkiewicz
approved these changes
Jul 14, 2020
| address: 1.1.1.1 | ||
| tags: | ||
| service: backend`, | ||
| }), |
There was a problem hiding this comment.
We've got should pass validation section above
added 2 commits
July 16, 2020 12:44
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As described in #891, we would like to extend the DataplaneResource to include a ServiceAddress field in the Inbound. This way the dataplane and the service can live in different IP netns, containers, VMs etc.
Remove the remains of the
Interfaceremove in #832. In the dataplaen helpers deletedParseInboundInterface,ParseOutboundInterface,ParsePort,ParseIP.Full changelog
Issues resolved
Fix #891
Documentation