Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When following log files, tail them rather than truncate them. #17

Merged
merged 2 commits into from Feb 15, 2019

Conversation

eklitzke
Copy link
Contributor

This change makes the exporter tail log files, meaning that the files can be opened read only and don't need to be truncated. This seems like a general all around win because:

  • It doesn't require any special syslog configuration to duplicate logs
  • The exporter process can be run by a user without write privileges to log files
  • This will likely work better out-of-the-box for most people

@jangrewe
Copy link
Contributor

jangrewe commented Nov 4, 2018

Thanks, that's a very sane idea.

@BartVerc
Copy link
Member

BartVerc commented Nov 6, 2018

Thanks for the pull request.
It looks like you are still using the duplicated log file since the default path to the log is the duplicated one.
Can you fix it so that the configured Postfix log file is used by default?

@BartVerc
Copy link
Member

Thanks for the work, it should have been merged earlier.

@BartVerc BartVerc merged commit 1b1c5f3 into kumina:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants