KIP-3: send revenue to the KUMO treasury #414
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marceljay
reviewed
Sep 28, 2023
|
|
||
| uint256 internal assetBalance; // deposited asset tracker | ||
| // Percent that goes to the depositor. 1e18 = 100%, 9e17 = 90%. Must be in range [0, 1] | ||
| uint256 internal kickbackRate; |
There was a problem hiding this comment.
I personally found the variable name already confusing when I first looked into Liquity 2 years ago. Why don't we name it commissionRate or systemFee?
There was a problem hiding this comment.
Choose protocolFee as I see it more often than other variants
| @@ -634,6 +634,27 @@ contract StabilityPool is KumoBase, CheckContract, IStabilityPool { | |||
| return KUSDGain; | |||
| } | |||
|
|
|||
| function _sendGainsToKUMOTreasury(uint256 _assetGain, uint256 _KUSDGain) internal { | |||
| uint256 treasuryShare = uint256(DECIMAL_PRECISION).sub(kickbackRate); | |||
There was a problem hiding this comment.
This is why I was confused about the term Kumo Wallet.
There was a problem hiding this comment.
Also, this would be easier if kickbackRate was just feePercentage or commissionRate or similar.
There was a problem hiding this comment.
I also confused with KUMO Wallet. I feel that KUMO Treasury is more obvious choise.
arthurka-o
force-pushed
the
KIP-3-revenue-to-KUMO-wallet
branch
3 times, most recently
from
37aae75
to
7a06217
Compare
arthurka-o
force-pushed
the
KIP-3-revenue-to-KUMO-wallet
branch
from
7a06217
to
0747a74
Compare
arthurka-o
force-pushed
the
KIP-3-revenue-to-KUMO-wallet
branch
from
0747a74
to
521c9b0
Compare
arthurka-o
force-pushed
the
KIP-3
branch
2 times, most recently
from
05a98ec
to
3b85772
Compare
added 6 commits
October 4, 2023 18:16
In this function, we calculate the treasury share in percents (1 - `kickbackRate`). Then, if the depositor gains are not zero, we send Asset and KUSD to the treasury address, and update pool balances.
By multiplying the gain amount by the kickback rate and dividing by `DECIMAL_PRECISION`, we get the amount of gain that depositors get minus treasury fee.
For every function that sends gains to somewhere, be it the depositor's trove or depositor's wallet, now we send a part of the gains to the KUMO treasury.
arthurka-o
force-pushed
the
KIP-3-revenue-to-KUMO-wallet
branch
from
521c9b0
to
283907c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.notion.so/kumos/Split-the-revenue-between-SP-providers-and-the-KUMO-treasury-587a4d1c66a8462eaf61623d1d2d30ba