KIP-3: Fix SDK-related packages #428
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## KIP-3 #428 +/- ##
=======================================
Coverage ? 0.00%
=======================================
Files ? 36
Lines ? 2332
Branches ? 264
=======================================
Hits ? 0
Misses ? 2332
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
arthurka-o
force-pushed
the
KIP-3-fix-SDK-related-packages
branch
2 times, most recently
from
9ef19b2
to
012e935
Compare
asimpk
force-pushed
the
KIP-3-fix-SDK-related-packages
branch
from
012e935
to
a787d68
Compare
arthurka-o
force-pushed
the
KIP-3-fix-SDK-related-packages
branch
from
a787d68
to
2f94852
Compare
arthurka-o
force-pushed
the
KIP-3
branch
2 times, most recently
from
05a98ec
to
3b85772
Compare
added 11 commits
October 5, 2023 09:35
`stakingAdmin`, `assetsStaked`, and `onlyStakingAdmin` were not used anywhere, so I removed them also.
Missed this in KIP-6, removing now
In this function, we calculate the treasury share in percents (1 - `kickbackRate`). Then, if the depositor gains are not zero, we send Asset and KUSD to the treasury address, and update pool balances.
By multiplying the gain amount by the kickback rate and dividing by `DECIMAL_PRECISION`, we get the amount of gain that depositors get minus treasury fee.
For every function that sends gains to somewhere, be it the depositor's trove or depositor's wallet, now we send a part of the gains to the KUMO treasury.
arthurka-o
force-pushed
the
KIP-3-fix-SDK-related-packages
branch
from
2f94852
to
d68aa9a
Compare
added 8 commits
October 5, 2023 09:47
Also, modify some functions and interfaces. Code that depended on those will be fixed in the following commits. `totalStabilityPoolKUMOReward` and `liquidityMiningKUMORewardRate` are deleted as a part of KUMO Token removal.
One variable and series of `KUMO Token`-related functions
Remove series of `KUMO Token`-related functions
added 13 commits
October 5, 2023 09:47
Not removing `KUMOStake` completely because it can be re-used. ref: kumo-earth#426
TS won't let me compile if I don't remove it
arthurka-o
force-pushed
the
KIP-3-fix-SDK-related-packages
branch
from
d68aa9a
to
f495d02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.notion.so/kumos/Fix-SDK-and-adjacent-packages-0dd4346af399449ab0a3c26e74060fff
Includes commits from #412 and #414