Skip to content

Commit

Permalink
ceph-volume: add is_ceph_device unit tests
Browse files Browse the repository at this point in the history
Signed-off-by: Jan Fajerski <jfajerski@suse.com>
  • Loading branch information
Jan Fajerski committed Feb 12, 2020
1 parent a825823 commit 60d8063
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions src/ceph-volume/ceph_volume/tests/api/test_lvm.py
Expand Up @@ -213,6 +213,24 @@ def test_single_vg_is_matched(self, volume_groups, monkeypatch):
assert api.get_vg(vg_name='foo') == FooVG


class TestVolume(object):

def test_is_ceph_device(self):
lv_tags = "ceph.type=data,ceph.osd_id=0"
osd = api.Volume(lv_name='osd/volume', lv_tags=lv_tags)
assert api.is_ceph_device(osd)

@pytest.mark.parametrize('dev',[
'/dev/sdb',
api.VolumeGroup(vg_name='foo'),
api.Volume(lv_name='vg/no_osd', lv_tags=''),
api.Volume(lv_name='vg/no_osd', lv_tags='ceph.osd_id=null'),
None,
])
def test_is_not_ceph_device(self, dev):
assert not api.is_ceph_device(dev)


class TestVolumes(object):

def test_volume_get_has_no_volumes(self, volumes):
Expand Down

0 comments on commit 60d8063

Please sign in to comment.