Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rnn methods #34

Closed
wants to merge 3 commits into from
Closed

Fix rnn methods #34

wants to merge 3 commits into from

Conversation

cbovar
Copy link
Contributor

@cbovar cbovar commented Apr 22, 2017

Hi, a few methods related to RNN didn't seem to have the right parameters.

The calls to those methods now succeed with those modifications (although I still don't know how to properly use cudn rnn methods see my questions to nvidia here)

@kunzmi
Copy link
Owner

kunzmi commented May 8, 2017

Thanks for contributing! Sorry for the late comment, I was travelling through California and I'm at GTC right now... I'll have a look at it once I'm back home.

@AeroClassics
Copy link

AeroClassics commented May 8, 2017 via email

@kunzmi
Copy link
Owner

kunzmi commented May 25, 2017

I went through your PR and it actually doesn't really fix the problem: In combination with pinvoke the use of "out" instead of "ref" is not recommended as the compiler can't check that the value is actually set. If the library, for what ever reason, does not set the value correctly the variable remains without defined value. This should never happen in managed world...
As for the wrong arguments: I fixed that now, at the same time I upgraded to cudnn v6.
In the RNN section are some argument types where I'm not 100% sure if they are correctly ported to C#. Some of your interpretations are wrong, again I'm not sure if I did it right.
Please check and don't hesitate to reopen the issue.

Cheers,
Michael

@kunzmi kunzmi closed this May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants