cleanup: remove redundant reconcile Returns when add finalizer

Signed-off-by: Xieql <xieqianglong@huawei.com>
kurator-dev · Oct 16, 2023 · 0104b02 · 0104b02
1 parent 269f04e
commit 0104b02
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 3 deletions.
diff --git a/pkg/cluster-operator/cluster_controller.go b/pkg/cluster-operator/cluster_controller.go
@@ -127,7 +127,6 @@ func (r *ClusterController) Reconcile(ctx context.Context, req ctrl.Request) (_
 		cluster.Status.Phase = string(capiv1.ClusterPhaseProvisioning)
 		conditions.MarkFalse(cluster, clusterv1alpha1.ReadyCondition, clusterv1alpha1.ProvisioningReason, capiv1.ConditionSeverityError, "Provisioning")
 		controllerutil.AddFinalizer(cluster, ClusterFinalizer)
-		return ctrl.Result{}, nil
 	}
 
 	// Handle deletion reconciliation loop.

diff --git a/pkg/fleet-manager/application_controller.go b/pkg/fleet-manager/application_controller.go
@@ -134,7 +134,6 @@ func (a *ApplicationManager) Reconcile(ctx context.Context, req ctrl.Request) (_
 	// Add finalizer if not exist to void the race condition.
 	if !controllerutil.ContainsFinalizer(app, ApplicationFinalizer) {
 		controllerutil.AddFinalizer(app, ApplicationFinalizer)
-		return ctrl.Result{}, nil
 	}
 
 	// there only one fleet, so pre-fetch it here.

diff --git a/pkg/fleet-manager/fleet.go b/pkg/fleet-manager/fleet.go
@@ -128,7 +128,6 @@ func (f *FleetManager) Reconcile(ctx context.Context, req ctrl.Request) (_ ctrl.
 	if !controllerutil.ContainsFinalizer(fleet, FleetFinalizer) {
 		fleet.Status.Phase = fleetapi.RunningPhase
 		controllerutil.AddFinalizer(fleet, FleetFinalizer)
-		return ctrl.Result{}, nil
 	}
 
 	// Handle deletion reconciliation loop.