Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove redundant reconciler returns when add finalizer #398

Merged
merged 1 commit into from Oct 17, 2023

Conversation

Xieql
Copy link
Contributor

@Xieql Xieql commented Oct 16, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

remove redundant reconcile returns when add finalizer

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

cleanup: remove redundant reconciler returns when add finalizer

Signed-off-by: Xieql <xieqianglong@huawei.com>
@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for kurator-dev canceled.

Name Link
🔨 Latest commit 0104b02
🔍 Latest deploy log https://app.netlify.com/sites/kurator-dev/deploys/652d2e0b4df6c70008e83197

Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kurator-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurator-bot kurator-bot merged commit c0e0844 into kurator-dev:main Oct 17, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants