Merge pull request rack#1045 from shhavel/feature/use_string_interpol…

…ation_instead_plus Use String interpolation or << instead plus which are faster
kuroda · Apr 12, 2016 · 9f7703e · 9f7703e
2 parents 2da7bd3 + 20214d7
commit 9f7703e
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 6 deletions.
diff --git a/lib/rack/auth/digest/params.rb b/lib/rack/auth/digest/params.rb
@@ -38,7 +38,7 @@ def []=(k, v)
 
         def to_s
           map do |k, v|
-            "#{k}=" + (UNQUOTED.include?(k) ? v.to_s : quote(v))
+            "#{k}=" << (UNQUOTED.include?(k) ? v.to_s : quote(v))
           end.join(', ')
         end
 
@@ -50,4 +50,3 @@ def quote(str) # From WEBrick::HTTPUtils
     end
   end
 end
-
diff --git a/lib/rack/common_logger.rb b/lib/rack/common_logger.rb
@@ -48,7 +48,7 @@ def log(env, status, header, began_at)
         now.strftime("%d/%b/%Y:%H:%M:%S %z"),
         env[REQUEST_METHOD],
         env[PATH_INFO],
-        env[QUERY_STRING].empty? ? "" : "?"+env[QUERY_STRING],
+        env[QUERY_STRING].empty? ? "" : "?#{env[QUERY_STRING]}",
         env[HTTP_VERSION],
         status.to_s[0..3],
         length,

diff --git a/lib/rack/directory.rb b/lib/rack/directory.rb
@@ -155,7 +155,7 @@ def filesize_format(int)
         return format % (int.to_f / size) if int >= size
       end
 
-      int.to_s + 'B'
+      "#{int}B"
     end
   end
 end
diff --git a/lib/rack/multipart/generator.rb b/lib/rack/multipart/generator.rb
@@ -22,7 +22,7 @@ def dump
           else
             content_for_other(file, name)
           end
-        end.join + "--#{MULTIPART_BOUNDARY}--\r"
+        end.join << "--#{MULTIPART_BOUNDARY}--\r"
       end
 
       private

diff --git a/lib/rack/multipart/parser.rb b/lib/rack/multipart/parser.rb
@@ -26,7 +26,7 @@ def read(size)
           str = if left < size
                   @io.read left
                 else
-                 @io.read size
+                  @io.read size
                 end
 
           if str