Make the initial connection process "drain aware" #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ain events to avoid collision. Only works in node 0.6
Conflicts: limestone.js
kurokikaze
added a commit
that referenced
this pull request
Mar 2, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of
I've added "drain" event support, so limestone won't write to the sphinx server before the previous written thing is complete.
send version number ---> wait for drain --> send persistent flat ---> wait for drain --> _connected=true
but, This only works on node 0.6. that's why I've put it apart from the master. I personally thing is not big deal, limestone is still in its early stage, but I leave it to you.
As usual, any comments are welcome.