-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add vc_count to increase the number of validators per participant #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckage into bbusa/vc_count
…ckage into bbusa/vc_count
Created #640 to fix some crashes I was having on this branch. Could you please review, there was one potential side-effect the PR may cause. Other than that it LGTM |
I ran into a few index out of bounds and divide by zero issues. I fixed those with what I expect is the right method. One thing I would like you to check is my change on the [participant_network.star](https://github.com/0xTylerHolmes/ethereum-package/blob/061dbec8694e78dfeb2cf9c48d351202866fd6e6/src/participant_network.star#L397) I added a check on the `vc_context` assignment for the case where `vc_count == 0`. We would get an index out of bounds panic so I just set it to `None`. I'm unsure if there are downstream consequences but everything appears to be working on my end with that. --------- Co-authored-by: Barnabas Busa <busa.barnabas@gmail.com>
parithosh
reviewed
May 28, 2024
parithosh
approved these changes
May 28, 2024
barnabasbusa
pushed a commit
that referenced
this pull request
Jun 10, 2024
🤖 I have created a release *beep* *boop* --- ## [3.1.0](3.0.0...3.1.0) (2024-06-07) ### Features * add http url to el context ([#656](#656)) ([4e69a4c](4e69a4c)) * add prefunded accounts to output ([#657](#657)) ([bc06e2a](bc06e2a)) * add tracoor ([#651](#651)) ([b100cb6](b100cb6)) * add vc_count to increase the number of validators per participant ([#633](#633)) ([4272ff3](4272ff3)) * allow setting custom dora image & env variables ([#623](#623)) ([08a65c3](08a65c3)) * **apache:** Serve all config files ([#606](#606)) ([3f1f5e1](3f1f5e1)) * **config:** add peerdas vars ([#619](#619)) ([22f1498](22f1498)) * expose network-params ([#659](#659)) ([b0820dd](b0820dd)) * forky ([#625](#625)) ([ded68bd](ded68bd)) * Support participants_matrix ([#620](#620)) ([3a57467](3a57467)) * use `peer-das` image for dora when eip7594 is active ([#593](#593)) ([1b4bd3d](1b4bd3d)) ### Bug Fixes * add additional prefund addresses ([#655](#655)) ([6d2cdb6](6d2cdb6)) * add cl log level to builders ([#638](#638)) ([ad46dbd](ad46dbd)) * Add EIP-7002 & EIP-2935 bytecode to ethereum-genesis-generator ([#597](#597)) ([3d316ef](3d316ef)) * add http to teku endpoint ([#622](#622)) ([085b6e1](085b6e1)) * add peer_das_epoch to egg ([#603](#603)) ([91694df](91694df)) * add sha256 as an image label (if present) ([#637](#637)) ([3dcf888](3dcf888)) * add static port config for apache ([#608](#608)) ([b96e502](b96e502)) * **apache:** only set static port if wanted ([#610](#610)) ([2c6b7b1](2c6b7b1)) * blockscout fix for json variant ([#662](#662)) ([e79c510](e79c510)) * churn adjustments ([#614](#614)) ([12ca872](12ca872)) * default config ([#632](#632)) ([14be117](14be117)) * drop everythign after [@sha](https://github.com/sha) from image labels ([#636](#636)) ([5d35463](5d35463)) * erigon v3 - new default image ([#629](#629)) ([72cf150](72cf150)) * genesis generator bump ([#611](#611)) ([5460f6f](5460f6f)) * nightly tests ([#595](#595)) ([76c31e9](76c31e9)) * pectra example ([#605](#605)) ([67e3da0](67e3da0)) * prysm vc key manager ports ([#639](#639)) ([81c1ee7](81c1ee7)) * re-add images to labels ([#634](#634)) ([71f6e28](71f6e28)) * README has invalid configs ([#631](#631)) ([e33b971](e33b971)) * readme indentation ([#600](#600)) ([583db1b](583db1b)) * registration flags when using beacon node only ([#618](#618)) ([c12506b](c12506b)) * repair check workflow for external PRs ([#616](#616)) ([a584682](a584682)) * seperate vc service names ([#654](#654)) ([a5ffe14](a5ffe14)) * tune Besu options to work with tx_spammer ([#612](#612)) ([b395189](b395189)) * update dora images ([#598](#598)) ([dd28d61](dd28d61)) * update prysm image ([#599](#599)) ([0a38114](0a38114)) * use `electra-support` image for assertoor when electra fork epoch is set ([#607](#607)) ([cdeab93](cdeab93)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.