Skip to content

Commit

Permalink
fix: make dry run return the right return value (#795)
Browse files Browse the repository at this point in the history
  • Loading branch information
h4ck3rk3y committed Jun 28, 2023
1 parent a5bc40c commit be5f6e7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cli/cli/commands/run/run.go
Expand Up @@ -481,7 +481,7 @@ func readAndPrintResponseLinesUntilClosed(responseLineChan <-chan *kurtosis_core
select {
case responseLine, isChanOpen := <-responseLineChan:
if !isChanOpen {
if !isRunSuccessful {
if !isRunSuccessful && !dryRun {
// This error thrown by the APIC is not informative right now as it just tells the user to look at errors
// in the above log. For this reason we're ignoring it and returning nil. This is exceptional to not clutter
// the CLI output. We should still use stacktrace.Propagate for other errors.
Expand Down

0 comments on commit be5f6e7

Please sign in to comment.