Skip to content

Commit

Permalink
fix: Update testsuite package name to match their location in Github (#…
Browse files Browse the repository at this point in the history
…1335)

## Description:
<!-- Describe this change, how it works, and the motivation behind it.
-->

## Is this change user facing?
NO
<!-- If yes, please add the "user facing" label to the PR -->
<!-- If yes, don't forget to include docs changes where relevant -->

## References (if applicable):
<!-- Add relevant Github Issues, Discord threads, or other helpful
information. -->
  • Loading branch information
Guillaume Bouvignies committed Sep 19, 2023
1 parent 022116a commit d5218a2
Show file tree
Hide file tree
Showing 14 changed files with 17 additions and 16 deletions.
Expand Up @@ -14,10 +14,10 @@ func (suite *StartosisPackageTestSuite) TestStartosisPackage_NoMainFile() {
runResult, _ := suite.RunPackage(ctx, packageWithNoMainStarRelPath)

t := suite.T()
expectedErrorContents := `An error occurred while verifying that 'main.star' exists in the package 'github.com/sample/sample-kurtosis-package' at '/kurtosis-data/startosis-packages/sample/sample-kurtosis-package/main.star'
Caused by: stat /kurtosis-data/startosis-packages/sample/sample-kurtosis-package/main.star: no such file or directory`
expectedErrorContents := `An error occurred while verifying that 'main.star' exists in the package 'github.com/kurtosis-tech/kurtosis/internal_testsuites/starlark/no-main-star' at '/kurtosis-data/startosis-packages/kurtosis-tech/kurtosis/internal_testsuites/starlark/no-main-star/main.star'
Caused by: stat /kurtosis-data/startosis-packages/kurtosis-tech/kurtosis/internal_testsuites/starlark/no-main-star/main.star: no such file or directory`
require.NotNil(t, runResult.InterpretationError)
require.Equal(t, runResult.InterpretationError.GetErrorMessage(), expectedErrorContents)
require.Equal(t, expectedErrorContents, runResult.InterpretationError.GetErrorMessage())
require.Empty(t, runResult.ValidationErrors)
require.Nil(t, runResult.ExecutionError)
require.Empty(t, string(runResult.RunOutput))
Expand Down
Expand Up @@ -14,7 +14,7 @@ func (suite *StartosisPackageTestSuite) TestStartosisPackage_NoMainInMainStar()
runResult, _ := suite.RunPackage(ctx, packageWithNoMainInMainStarRelPath)

t := suite.T()
expectedInterpretationErr := "No 'run' function found in the main file of package 'github.com/sample/sample-kurtosis-package'; a 'run' entrypoint function with the signature `run(plan, args)` or `run()` is required in the main file of the Kurtosis package"
expectedInterpretationErr := "No 'run' function found in the main file of package 'github.com/kurtosis-tech/kurtosis/internal_testsuites/starlark/no-run-in-main-star'; a 'run' entrypoint function with the signature `run(plan, args)` or `run()` is required in the main file of the Kurtosis package"
require.NotNil(t, runResult.InterpretationError)
require.Contains(t, runResult.InterpretationError.GetErrorMessage(), expectedInterpretationErr)
require.Empty(t, runResult.ValidationErrors)
Expand Down
Expand Up @@ -29,10 +29,10 @@ const (
)

var (
noExperimentalFeature = []kurtosis_core_rpc_api_bindings.KurtosisFeatureFlag{}
noExperimentalFeature []kurtosis_core_rpc_api_bindings.KurtosisFeatureFlag
)

func TestStartosisPackage_ValidPackageWithInput(t *testing.T) {
func TestStartosisPackage_UploadFileAndCheckFileHash(t *testing.T) {
t.Parallel()
ctx := context.Background()

Expand Down
@@ -1 +1 @@
name: "github.com/sample/sample-kurtosis-package/subpackage-module"
name: "github.com/kurtosis-tech/kurtosis/internal_testsuites/starlark/kurtosis-sub-package/subpackage-module"
2 changes: 1 addition & 1 deletion internal_testsuites/starlark/no-main-star/kurtosis.yml
@@ -1 +1 @@
name: "github.com/sample/sample-kurtosis-package"
name: "github.com/kurtosis-tech/kurtosis/internal_testsuites/starlark/no-main-star"
@@ -1 +1 @@
name: "github.com/sample/sample-kurtosis-package"
name: "github.com/kurtosis-tech/kurtosis/internal_testsuites/starlark/no-run-in-main-star"
2 changes: 1 addition & 1 deletion internal_testsuites/starlark/no-run-in-main-star/main.star
@@ -1 +1 @@
lib = import_module("github.com/sample/sample-kurtosis-package/lib/lib.star")
lib = import_module("github.com/kurtosis-tech/kurtosis/internal_testsuites/starlark/no-run-in-main-star/lib/lib.star")
@@ -1 +1 @@
name: "github.com/sample/sample-kurtosis-package"
name: "github.com/kurtosis-tech/kurtosis/internal_testsuites/starlark/upload-file-package"
2 changes: 1 addition & 1 deletion internal_testsuites/starlark/upload-file-package/main.star
Expand Up @@ -3,7 +3,7 @@
# named large-file.bin. This file is generated on the spot to avoid checking it into GitHub
def run(plan, args):
plan.print("Starting upload")
large_file_artifact_id = plan.upload_files("github.com/sample/sample-kurtosis-package/large-file.bin")
large_file_artifact_id = plan.upload_files("github.com/kurtosis-tech/kurtosis/internal_testsuites/starlark/upload-file-package/large-file.bin")

plan.print("Upload finished - Comparing file hash to parameter")

Expand Down
@@ -1 +1 @@
name: "github.com/sample/sample-kurtosis-package"
name: "github.com/kurtosis-tech/kurtosis/internal_testsuites/starlark/valid-kurtosis-package-no-input"
@@ -1 +1 @@
name: "github.com/sample/sample-kurtosis-package"
name: "github.com/kurtosis-tech/kurtosis/internal_testsuites/starlark/valid-kurtosis-package-with-input"
@@ -1,4 +1,4 @@
lib = import_module("github.com/sample/sample-kurtosis-package/lib/lib.star")
lib = import_module("github.com/kurtosis-tech/kurtosis/internal_testsuites/starlark/valid-kurtosis-package-with-input/lib/lib.star")


def run(plan, args):
Expand Down
@@ -1 +1 @@
name: "github.com/sample/sample-kurtosis-package"
name: "github.com/kurtosis-tech/kurtosis/internal_testsuites/starlark/valid-package-with-relative-imports"
@@ -1,6 +1,7 @@
lib = import_module("./src/lib.star")
password = read_file("./static_files/password.txt")


def run(plan):
plan.upload_files("./static_files/password.txt", "upload")
plan.print(lib.NAME)
Expand Down

0 comments on commit d5218a2

Please sign in to comment.