Skip to content

Commit

Permalink
fix: Fix comment about sidecar (#1053)
Browse files Browse the repository at this point in the history
## Description:
Just changing the wording of an error message to reflect what Kurtosis
is actually doing.

## Is this change user facing?
NO
<!-- If yes, please add the "user facing" label to the PR -->
<!-- If yes, don't forget to include docs changes where relevant -->

## References (if applicable):
<!-- Add relevant Github Issues, Discord threads, or other helpful
information. -->
  • Loading branch information
Guillaume Bouvignies committed Aug 3, 2023
1 parent 510ffe2 commit d9b07ea
Showing 1 changed file with 2 additions and 2 deletions.
Expand Up @@ -1446,15 +1446,15 @@ func (network *DefaultServiceNetwork) destroyService(ctx context.Context, servic
}
successfullyDestroyedUuids, failedToDestroyUuids, err := network.kurtosisBackend.DestroyUserServices(context.Background(), network.enclaveUuid, userServiceFilters)
if err != nil {
return stacktrace.Propagate(err, "Attempted to destroy the services with UUID '%v' but had no success. You must manually destroy the services. Kurtosis will now try to remove its sidecar if it exists but might it fail as well.", serviceUuid)
return stacktrace.Propagate(err, "Attempted to destroy the service with UUID '%v' but had no success. You must manually destroy the service as well as its sidecar if any", serviceUuid)
}
if _, found := successfullyDestroyedUuids[serviceUuid]; found {
if len(failedToDestroyUuids) != 0 {
return stacktrace.NewError("Service '%s' was successfully destroyed but unexpected error were returned by Kurtosis backend. This is unexpected and should be investigated. Here are the errors:\n%v", serviceUuid, failedToDestroyUuids)
}
} else {
if failedToDestroyErr, found := failedToDestroyUuids[serviceUuid]; found {
return stacktrace.Propagate(failedToDestroyErr, "Attempted to destroy the services with UUID '%v' but had no success. You must manually destroy the services. Kurtosis will now try to remove its sidecar if it exists but might it fail as well.", serviceUuid)
return stacktrace.Propagate(failedToDestroyErr, "Attempted to destroy the service with UUID '%v' but had no success. You must manually destroy the service as well as its sidecar if any", serviceUuid)
} else {
return stacktrace.NewError("Attempted to destroy service '%s' but it was neither marked as successfully destroyed nor errored in the result. This is a Kurtosis bug", serviceUuid)
}
Expand Down

0 comments on commit d9b07ea

Please sign in to comment.