Skip to content

Commit

Permalink
fix: remove historical enclave names from auto complete (#1059)
Browse files Browse the repository at this point in the history
## Description:
We used to populate historical enclave names and service names in auto
complete but that was confusing to me and Barnabas.
  • Loading branch information
h4ck3rk3y committed Aug 3, 2023
1 parent 069ccfd commit e63fd88
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions cli/cli/commands/service/logs/logs.go
Expand Up @@ -105,17 +105,16 @@ var ServiceLogsCmd = &engine_consuming_kurtosis_command.EngineConsumingKurtosisC
Args: []*args.ArgConfig{
//TODO disabling enclaveID validation and serviceUUID validation for allowing consuming logs from removed or stopped enclaves
//TODO we should enable them when #879 is ready: https://github.com/kurtosis-tech/kurtosis/issues/879
enclave_id_arg.NewHistoricalEnclaveIdentifiersArgWithValidationDisabled(
enclave_id_arg.NewEnclaveIdentifierArg(
enclaveIdentifierArgKey,
engineClientCtxKey,
isEnclaveIdArgOptional,
isEnclaveIdArgGreedy,
),
// TODO use the `NewServiceIdentifierArg` instead when we start storing identifiers in DB
// TODO we should fix this after https://github.com/kurtosis-tech/kurtosis/issues/879
service_identifier_arg.NewHistoricalServiceIdentifierArgWithValidationDisabled(
service_identifier_arg.NewServiceIdentifierArg(
serviceIdentifierArgKey,
isServiceIdentifierArgOptional,
isServiceIdentifierArgGreedy,
isServiceIdentifierArgOptional,
),
},
RunFunc: run,
Expand Down

0 comments on commit e63fd88

Please sign in to comment.