Skip to content

Commit

Permalink
fix: moving the golangci-lint condition because it has matrix strategy (
Browse files Browse the repository at this point in the history
#2242)

## Description:
moving the golangci-lint condition because it has matrix strategy

We have to move the condition to the steps section otherwise these jobs
won't be executed when a doc's PR is created.

## Is this change user facing?
NO

## References (if applicable):
<!-- Add relevant Github Issues, Discord threads, or other helpful
information. -->
  • Loading branch information
leoporoli committed Mar 1, 2024
1 parent 1b6aff7 commit f976daa
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .github/workflows/golangci-lint.yml
Expand Up @@ -39,7 +39,6 @@ jobs:
id: check
golangci:
needs: check-if-code-change
if: ${{ needs.check-if-code-change.outputs.change == 'true' }}
name: golang-lint
runs-on: ubuntu-latest
strategy:
Expand All @@ -59,12 +58,16 @@ jobs:
- cli/cli
steps:
- uses: actions/setup-go@v5
if: ${{ needs.check-if-code-change.outputs.change == 'true' }}
with:
go-version: '1.20'
- uses: actions/checkout@v4
if: ${{ needs.check-if-code-change.outputs.change == 'true' }}
# Generate versions
- run: scripts/generate-kurtosis-version.sh
if: ${{ needs.check-if-code-change.outputs.change == 'true' }}
- name: lint-container-engine-lib
if: ${{ needs.check-if-code-change.outputs.change == 'true' }}
uses: golangci/golangci-lint-action@v4
with:
version: ${{ env.GOLINT_VERSION }}
Expand Down

0 comments on commit f976daa

Please sign in to comment.