fix: Remove the temp cert files only after the docker client is initialized #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentluce
changed the title
gbouv
approved these changes
Jul 31, 2023
...gine-lib/lib/backend_impls/docker/docker_kurtosis_backend/backend_creator/backend_creator.go
Outdated
Show resolved
Hide resolved
adschwartz
pushed a commit
that referenced
this pull request
Aug 2, 2023
🤖 I have created a release *beep* *boop* --- ## [0.80.24](0.80.23...0.80.24) (2023-08-01) ### Features * Persistent directories for docker ([#1034](#1034)) ([2f909c3](2f909c3)) * Persistent directories for Kubernetes ([#1036](#1036)) ([4488986](4488986)) ### Bug Fixes * Remove the temp cert files only after the docker client is initialized ([#1030](#1030)) ([1a6bb74](1a6bb74)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The temp cert files were removed before the docker client got a chance to read them to build a TLS config. Not sure if this was due to a race condition or a recent change in the docker client.
Is this change user facing?
NO