feat: Persistent directories for Kubernetes #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbouv
force-pushed
the
gbouv/persistent-directory-kubernetes
branch
2 times, most recently
from
7bbdbdb
to
78172f6
Compare
gbouv
force-pushed
the
gbouv/persistent-directory-kubernetes
branch
from
78172f6
to
65bdad2
Compare
leoporoli
reviewed
Aug 1, 2023
...pls/kubernetes/kubernetes_kurtosis_backend/user_services_functions/persistent_directories.go
Show resolved
Hide resolved
leoporoli
reviewed
Aug 1, 2023
...pls/kubernetes/kubernetes_kurtosis_backend/user_services_functions/persistent_directories.go
Show resolved
Hide resolved
leoporoli
reviewed
Aug 1, 2023
container-engine-lib/lib/backend_impls/kubernetes/kubernetes_manager/kubernetes_manager.go
Show resolved
Hide resolved
leoporoli
reviewed
Aug 1, 2023
container-engine-lib/lib/backend_impls/kubernetes/kubernetes_manager/kubernetes_manager.go
Show resolved
Hide resolved
leoporoli
reviewed
Aug 1, 2023
container-engine-lib/lib/backend_impls/kubernetes/kubernetes_manager/kubernetes_manager.go
Outdated
Show resolved
Hide resolved
leoporoli
reviewed
Aug 1, 2023
container-engine-lib/lib/backend_impls/kubernetes/kubernetes_manager/kubernetes_manager.go
Show resolved
Hide resolved
leoporoli
approved these changes
Aug 1, 2023
adschwartz
pushed a commit
that referenced
this pull request
Aug 2, 2023
🤖 I have created a release *beep* *boop* --- ## [0.80.24](0.80.23...0.80.24) (2023-08-01) ### Features * Persistent directories for docker ([#1034](#1034)) ([2f909c3](2f909c3)) * Persistent directories for Kubernetes ([#1036](#1036)) ([4488986](4488986)) ### Bug Fixes * Remove the temp cert files only after the docker client is initialized ([#1030](#1030)) ([1a6bb74](1a6bb74)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds the docker backend to support persistent directories for user services. For now, we use
hostPathpersistent volumes, which will break if the user service is restarted onto a different k8s node than what it was before. There's plenty of ways to fix that (using k8slocalpersistent volumes, re-scheduling the pod on the same node as where it was before, using a shared block store like EBS on AWS, etc) but we are lacking concrete use cases to choose the best option right now.hostPathworks for now and is the simplest implementation.Is this change user facing?
NO
References (if applicable):