feat: implement new logging architecture v0 #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedim52
changed the title
tedim52
force-pushed
the
tedi/log-aggregator
branch
from
bd1296d
to
7eefb51
Compare
tedim52
force-pushed
the
tedi/log-aggregator
branch
from
71f3fce
to
99e5e9a
Compare
tedim52
changed the title
tedim52
force-pushed
the
tedi/log-aggregator
branch
from
7045358
to
151b6cf
Compare
gbouv
approved these changes
Aug 11, 2023
...ine-lib/lib/backend_impls/docker/docker_kurtosis_backend/engine_functions/destroy_engines.go
Outdated
Show resolved
Hide resolved
...end_impls/docker/docker_kurtosis_backend/logs_aggregator_functions/create_logs_aggregator.go
Show resolved
Hide resolved
...lib/backend_impls/docker/docker_kurtosis_backend/logs_aggregator_functions/shared_helpers.go
Outdated
Show resolved
Hide resolved
.../docker/docker_kurtosis_backend/logs_collector_functions/implementations/fluentbit/consts.go
Show resolved
Hide resolved
...nd_impls/docker/docker_kurtosis_backend/logs_collector_functions/logs_collector_container.go
Show resolved
Hide resolved
leeederek
pushed a commit
that referenced
this pull request
Aug 14, 2023
🤖 I have created a release *beep* *boop* --- ## [0.81.6](0.81.5...0.81.6) (2023-08-11) ### Features * add more endpoints to support the Cloud ([#1077](#1077)) ([1d70382](1d70382)) * enable streaming exec output in container engine [stream exec pt. 1] ([#1043](#1043)) ([e8f34ef](e8f34ef)) * implement new logging architecture v0 ([#1071](#1071)) ([c66c148](c66c148)) * make enclave namespace and network naming deterministic ([#1100](#1100)) ([0d42106](0d42106)) * Persist file artifacts ([#1084](#1084)) ([c7b3590](c7b3590)) * Portal automatic start and stop on context change ([#1086](#1086)) ([a6a73d1](a6a73d1)), closes [#970](#970) * Update files if already present in enclave ([#1066](#1066)) ([1135543](1135543)) ### Bug Fixes * Add API key to endpoint ([#1102](#1102)) ([64f0c20](64f0c20)) * Fix issue with idempotent plan resolution ([#1087](#1087)) ([fd48f8f](fd48f8f)) * Forward the engine port after verifying that an engine container is running and before initializing the engine client ([#1099](#1099)) ([b0b7a3b](b0b7a3b)) * update golang docker client to latest ([#1082](#1082)) ([724084f](724084f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
tedim52
added a commit
that referenced
this pull request
Aug 21, 2023
## Description: This PR is the v1 for the centralized logging architecture over Docker. Specifically, it makes the following changes: - Creates a Docker volume to hold logs in - Mounts the `LogsAggregator` and `engine` to this volume - Configures `LogsAggregator` to store logs in volume - Configures `engine` to retrieve logs from volume via `PersistentVolumeLogsDatabaseClient` - Adjust CLI to allow passing in service and enclave ids for removed user service or api containers ## Is this change user facing? NO ## References (if applicable): #1071
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR finalizes v0 of centralized logging over Docker. Specifically, it makes the following changes:
LogsDatabasecode (including loki implementations)LogsCollectorsrunning per enclaveLogsAggregatorcomponentLogsAggregatorusing VectorAPIContainerto send logs to its respective enclave fluentbit logs collectorIs this change user facing?
NO