feat: Update files if already present in enclave #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbouv
force-pushed
the
gbouv/file-upload-update
branch
3 times, most recently
from
fd5c472
to
a7b6b3b
Compare
gbouv
force-pushed
the
gbouv/file-upload-update
branch
from
a7b6b3b
to
2d92530
Compare
leoporoli
reviewed
Aug 7, 2023
leoporoli
reviewed
Aug 7, 2023
container-engine-lib/lib/backend_impls/kubernetes/kubernetes_manager/kubernetes_manager.go
Outdated
Show resolved
Hide resolved
leoporoli
reviewed
Aug 7, 2023
container-engine-lib/lib/backend_impls/kubernetes/kubernetes_manager/kubernetes_manager.go
Outdated
Show resolved
Hide resolved
leoporoli
reviewed
Aug 7, 2023
core/server/api_container/server/service_network/default_service_network.go
Outdated
Show resolved
Hide resolved
leoporoli
reviewed
Aug 7, 2023
core/server/api_container/server/service_network/default_service_network.go
Show resolved
Hide resolved
leoporoli
reviewed
Aug 7, 2023
...rver/api_container/server/startosis_engine/kurtosis_instruction/upload_files/upload_files.go
Outdated
Show resolved
Hide resolved
gbouv
force-pushed
the
gbouv/file-upload-update
branch
from
a93ce23
to
0be5130
Compare
leoporoli
added a commit
that referenced
this pull request
Aug 8, 2023
Right now, when a Starlark package creates a file artifact (via `upload_files`, `render_template`, or `store_service_file`), if a file artifact already exist with that name inside the enclave, it fails. This is a big pain for idempotency. This PR introduces files artifact updates. From now on, when a files artifact is "created" via starlark and already exists in the enclave (based on its artifact name), Kurtosis will check the equality of the files based on their hash, and if they are different the files artifact will be replaced by the new one (and of course it no-ops if they are the same). No change requires in the Starlark packages YES <!-- If yes, please add the "user facing" label to the PR --> <!-- If yes, don't forget to include docs changes where relevant --> <!-- Add relevant Github Issues, Discord threads, or other helpful information. -->
leeederek
pushed a commit
that referenced
this pull request
Aug 14, 2023
🤖 I have created a release *beep* *boop* --- ## [0.81.6](0.81.5...0.81.6) (2023-08-11) ### Features * add more endpoints to support the Cloud ([#1077](#1077)) ([1d70382](1d70382)) * enable streaming exec output in container engine [stream exec pt. 1] ([#1043](#1043)) ([e8f34ef](e8f34ef)) * implement new logging architecture v0 ([#1071](#1071)) ([c66c148](c66c148)) * make enclave namespace and network naming deterministic ([#1100](#1100)) ([0d42106](0d42106)) * Persist file artifacts ([#1084](#1084)) ([c7b3590](c7b3590)) * Portal automatic start and stop on context change ([#1086](#1086)) ([a6a73d1](a6a73d1)), closes [#970](#970) * Update files if already present in enclave ([#1066](#1066)) ([1135543](1135543)) ### Bug Fixes * Add API key to endpoint ([#1102](#1102)) ([64f0c20](64f0c20)) * Fix issue with idempotent plan resolution ([#1087](#1087)) ([fd48f8f](fd48f8f)) * Forward the engine port after verifying that an engine container is running and before initializing the engine client ([#1099](#1099)) ([b0b7a3b](b0b7a3b)) * update golang docker client to latest ([#1082](#1082)) ([724084f](724084f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Right now, when a Starlark package creates a file artifact (via
upload_files,render_template, orstore_service_file), if a file artifact already exist with that name inside the enclave, it fails. This is a big pain for idempotency.This PR introduces files artifact updates. From now on, when a files artifact is "created" via starlark and already exists in the enclave (based on its artifact name), Kurtosis will check the equality of the files based on their hash, and if they are different the files artifact will be replaced by the new one (and of course it no-ops if they are the same).
No change requires in the Starlark packages
Is this change user facing?
YES
References (if applicable):