feat: Portal automatic start and stop on context change #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text and automatically stop the portal when the user switches to a local context - Add option to pin the portal version.
gbouv
reviewed
Aug 9, 2023
…w portal binary file each time to not hit the signature caching issue.
gbouv
approved these changes
Aug 10, 2023
leeederek
pushed a commit
that referenced
this pull request
Aug 14, 2023
🤖 I have created a release *beep* *boop* --- ## [0.81.6](0.81.5...0.81.6) (2023-08-11) ### Features * add more endpoints to support the Cloud ([#1077](#1077)) ([1d70382](1d70382)) * enable streaming exec output in container engine [stream exec pt. 1] ([#1043](#1043)) ([e8f34ef](e8f34ef)) * implement new logging architecture v0 ([#1071](#1071)) ([c66c148](c66c148)) * make enclave namespace and network naming deterministic ([#1100](#1100)) ([0d42106](0d42106)) * Persist file artifacts ([#1084](#1084)) ([c7b3590](c7b3590)) * Portal automatic start and stop on context change ([#1086](#1086)) ([a6a73d1](a6a73d1)), closes [#970](#970) * Update files if already present in enclave ([#1066](#1066)) ([1135543](1135543)) ### Bug Fixes * Add API key to endpoint ([#1102](#1102)) ([64f0c20](64f0c20)) * Fix issue with idempotent plan resolution ([#1087](#1087)) ([fd48f8f](fd48f8f)) * Forward the engine port after verifying that an engine container is running and before initializing the engine client ([#1099](#1099)) ([b0b7a3b](b0b7a3b)) * update golang docker client to latest ([#1082](#1082)) ([724084f](724084f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The user currently needs to make sure that the portal is running before switching to a remote context. This change does that automatically for the user. This change also stops the portal when the context switches back to local.
Add the portal release tag to install so we can pin a portal version instead of using the latest. The portal release tag can also be set to "latest". This PR pins the portal version to 0.0.4
Upcoming changes:
Is this change user facing?
YES
References (if applicable):
Closes #970