Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple services to be stopped with the same command #1089

Closed
barnabasbusa opened this issue Aug 10, 2023 · 4 comments · Fixed by #1304 or #1328
Closed

Allow multiple services to be stopped with the same command #1089

barnabasbusa opened this issue Aug 10, 2023 · 4 comments · Fixed by #1304 or #1328
Assignees
@victorcolombo
Labels
feature request good first issue Good for newcomers nice to have Nice to have feature

Comments

@barnabasbusa
Copy link
Contributor

Background & motivation

Currently I can not stop more than one service at a time:

kurtosis service stop pristine-bay testnet-verifier prelaunch-data-generator-cl-genesis-data
Error:  accepts between 2 and 2 arg(s), received 3

Desired behaviour

I should be able to stop as many services as I want with the same command.
Also autocomplete the different services (that are not yet stopped).

How important is this to you?

Nice to have; this feature would make using Kurtosis more enjoyable.
@github-actions github-actions bot added the nice to have Nice to have feature label Aug 10, 2023
@mieubrisse mieubrisse mentioned this issue Aug 10, 2023
Closed
@ericobi
Copy link

ericobi commented Aug 10, 2023

I would like to work on this

@mieubrisse mieubrisse added the good first issue Good for newcomers label Aug 10, 2023
@mieubrisse
Copy link
Member

Thanks @ericobi ! It should be a very small change - just making the arg greedy

@mieubrisse
Copy link
Member

Hey @ericobi , just wanted to follow up if you had a chance to look at this!

@leeederek
Copy link
Contributor

@ericobi - hi did you have a chance to take a look at this?

@victorcolombo victorcolombo self-assigned this Sep 13, 2023
@victorcolombo victorcolombo mentioned this issue Sep 14, 2023
Merged
victorcolombo added a commit that referenced this issue Sep 14, 2023
@victorcolombo
Merge branch 'main' into vcolombo/gh-1089
1ed2ec4
victorcolombo added a commit that referenced this issue Sep 18, 2023
@victorcolombo
Merge branch 'main' into vcolombo/gh-1089
ee8753b
victorcolombo added a commit that referenced this issue Sep 18, 2023
@victorcolombo
Merge branch 'main' into vcolombo/gh-1089
417ab31
victorcolombo added a commit that referenced this issue Sep 18, 2023
@victorcolombo
Merge branch 'main' into vcolombo/gh-1089
ef575dc
victorcolombo added a commit that referenced this issue Sep 18, 2023
@victorcolombo
Merge branch 'main' into vcolombo/gh-1089
69889a1
victorcolombo added a commit that referenced this issue Sep 18, 2023
@victorcolombo
Merge branch 'main' into vcolombo/gh-1089
ffe7420
victorcolombo added a commit that referenced this issue Sep 18, 2023
@victorcolombo
feat: Make service start and stop support multiple services (#1304)
1b34b00 
## Description:
<!-- Describe this change, how it works, and the motivation behind it.
-->

## Is this change user facing?
YES
<!-- If yes, please add the "user facing" label to the PR -->
<!-- If yes, don't forget to include docs changes where relevant -->

## References (if applicable):
<!-- Add relevant Github Issues, Discord threads, or other helpful
information. -->
Closes #1089
@kurtosisbot kurtosisbot mentioned this issue Sep 18, 2023
Merged
adschwartz added a commit that referenced this issue Sep 18, 2023
@kurtosisbot @adschwartz
chore(main): release 0.83.2 (#1328)
0b81e7a 
🤖 I have created a release *beep* *boop*
---


##
[0.83.2](0.83.1...0.83.2)
(2023-09-18)


### Features

* disable line numbers and use the name of the file...
([#1329](#1329))
([1fd0e5a](1fd0e5a))
* Make service start and stop support multiple services
([#1304](#1304))
([1b34b00](1b34b00)),
closes [#1089](#1089)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Co-authored-by: Anders Schwartz <adschwartz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@victorcolombo victorcolombo

Labels
feature request good first issue Good for newcomers nice to have Nice to have feature
Projects
None yet
Milestone
No milestone
5 participants
@mieubrisse @victorcolombo @barnabasbusa @ericobi @leeederek