Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make enclave namespace and network naming deterministic #1100

Merged
merged 7 commits into from Aug 11, 2023
Merged

Conversation

tedim52
Copy link
Contributor

@tedim52 tedim52 commented Aug 11, 2023

Description:

  • Limit enclave names to 60 chars
  • Make Kubernetes namespace and Docker network names be kt-ENCLAVENAME

Is this change user facing?

YES

@tedim52 tedim52 changed the title feat: make enclave naming deterministic feat: make enclave namespace and network naming deterministic Aug 11, 2023
@mieubrisse
Copy link
Member

Fixes #934

@tedim52 tedim52 enabled auto-merge (squash) August 11, 2023 13:54
@tedim52 tedim52 merged commit 0d42106 into main Aug 11, 2023
29 checks passed
@tedim52 tedim52 deleted the tedi/names branch August 11, 2023 14:10
leeederek pushed a commit that referenced this pull request Aug 14, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.81.6](0.81.5...0.81.6)
(2023-08-11)


### Features

* add more endpoints to support the Cloud
([#1077](#1077))
([1d70382](1d70382))
* enable streaming exec output in container engine [stream exec pt. 1]
([#1043](#1043))
([e8f34ef](e8f34ef))
* implement new logging architecture v0
([#1071](#1071))
([c66c148](c66c148))
* make enclave namespace and network naming deterministic
([#1100](#1100))
([0d42106](0d42106))
* Persist file artifacts
([#1084](#1084))
([c7b3590](c7b3590))
* Portal automatic start and stop on context change
([#1086](#1086))
([a6a73d1](a6a73d1)),
closes [#970](#970)
* Update files if already present in enclave
([#1066](#1066))
([1135543](1135543))


### Bug Fixes

* Add API key to endpoint
([#1102](#1102))
([64f0c20](64f0c20))
* Fix issue with idempotent plan resolution
([#1087](#1087))
([fd48f8f](fd48f8f))
* Forward the engine port after verifying that an engine container is
running and before initializing the engine client
([#1099](#1099))
([b0b7a3b](b0b7a3b))
* update golang docker client to latest
([#1082](#1082))
([724084f](724084f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants