feat: retain logs for x weeks #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedim52
commented
Sep 5, 2023
gbouv
reviewed
Sep 5, 2023
...ngine-lib/lib/backend_impls/docker/docker_kurtosis_backend/engine_functions/create_engine.go
Outdated
Show resolved
Hide resolved
...ngine-lib/lib/backend_impls/docker/docker_kurtosis_backend/engine_functions/create_engine.go
Outdated
Show resolved
Hide resolved
...ngine-lib/lib/backend_impls/docker/docker_kurtosis_backend/engine_functions/create_engine.go
Outdated
Show resolved
Hide resolved
engine/server/engine/centralized_logs/client_implementations/persistent_volume/consts/consts.go
Outdated
Show resolved
Hide resolved
.../engine/centralized_logs/client_implementations/persistent_volume/log_remover/log_remover.go
Outdated
Show resolved
Hide resolved
...ient_implementations/persistent_volume/stream_logs_strategy/per_week_stream_logs_strategy.go
Outdated
Show resolved
Hide resolved
...ient_implementations/persistent_volume/stream_logs_strategy/per_week_stream_logs_strategy.go
Outdated
Show resolved
Hide resolved
...ralized_logs/client_implementations/persistent_volume/volume_filesystem/volume_filesystem.go
Show resolved
Hide resolved
gbouv
reviewed
Sep 6, 2023
...ngine-lib/lib/backend_impls/docker/docker_kurtosis_backend/engine_functions/create_engine.go
Outdated
Show resolved
Hide resolved
...ngine-lib/lib/backend_impls/docker/docker_kurtosis_backend/engine_functions/create_engine.go
Outdated
Show resolved
Hide resolved
...ngine-lib/lib/backend_impls/docker/docker_kurtosis_backend/engine_functions/create_engine.go
Show resolved
Hide resolved
...ls/docker/docker_kurtosis_backend/logs_aggregator_functions/implementations/vector/consts.go
Show resolved
Hide resolved
.../engine/centralized_logs/client_implementations/persistent_volume/log_remover/log_remover.go
Outdated
Show resolved
Hide resolved
.../engine/centralized_logs/client_implementations/persistent_volume/log_remover/log_remover.go
Outdated
Show resolved
Hide resolved
...ne/centralized_logs/client_implementations/persistent_volume/log_remover/log_remover_test.go
Outdated
Show resolved
Hide resolved
...ient_implementations/persistent_volume/stream_logs_strategy/per_week_stream_logs_strategy.go
Outdated
Show resolved
Hide resolved
...ient_implementations/persistent_volume/stream_logs_strategy/per_week_stream_logs_strategy.go
Show resolved
Hide resolved
gbouv
approved these changes
Sep 7, 2023
...ne/centralized_logs/client_implementations/persistent_volume/log_remover/log_remover_test.go
Outdated
Show resolved
Hide resolved
...ient_implementations/persistent_volume/stream_logs_strategy/per_file_stream_logs_strategy.go
Outdated
Show resolved
Hide resolved
leeederek
pushed a commit
that referenced
this pull request
Sep 11, 2023
🤖 I have created a release *beep* *boop* --- ## [0.82.22](0.82.21...0.82.22) (2023-09-11) ### Features * always pull latest image ([#1267](#1267)) ([6706809](6706809)) * CLI run command option to disable user services port forwarding ([#1252](#1252)) ([1c94378](1c94378)), closes [#1236](#1236) * retain logs for x weeks ([#1235](#1235)) ([5f50c8c](5f50c8c)) ### Bug Fixes * inline upgrade warning ([#1254](#1254)) ([33ef03a](33ef03a)), closes [#1244](#1244) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is the final PR in centralized logging v0 over Docker. Specifically,
It implements basic log retention by retaining logs for 5 weeks and removing logs older than that period. (To support pulling logs from enclaves created prior to this feature until all users are migrated, pull strategy is based on the enclaves creation time. Although, logs created prior to this feature will not be removed via log retention.)
Overall, this allows users to retrieve logs from services in long running enclaves up to 4 weeks prior.
Is this change user facing?
YES