Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI option to disable user services port forwarding #1236

Closed
laurentluce opened this issue Sep 5, 2023 · 0 comments · Fixed by #1252 or #1256
Closed

CLI option to disable user services port forwarding #1236

laurentluce opened this issue Sep 5, 2023 · 0 comments · Fixed by #1252 or #1256
Assignees
Labels

Comments

@laurentluce
Copy link
Contributor

Background & motivation

User services port forwarding is done automatically even if some users don't need it. Some users would like to be able to disable port forwarding and do it themselves for the required ports. This is needed until we can provide a complete Connect API where the user has control over what gets forwarded.

Desired behaviour

The user should be able to disable port forwarding by passing the flag --no-connect to the CLI run command.

How important is this to you?

Painful; the lack of this feature makes using Kurtosis frictionful.

@laurentluce laurentluce self-assigned this Sep 5, 2023
@github-actions github-actions bot added the painful Painful bug label Sep 5, 2023
laurentluce added a commit that referenced this issue Sep 11, 2023
…#1252)

## Description:
Add a `--no-connect` flag to the CLI run command. If set the user
service ports are not forwarded locally. In the case of K8S, the port
forward logic in the Gateway is disabled and the user services public
ip/port is not displayed in the enclave info. In the case of Docker, the
forward port calls are not sent to the Portal client but the ports are
still exposed on the Docker instance since this is managed by Docker
backend. It is acceptable for now since the K8S use case is higher
priority. A subsequent PR will be created to clean up the Docker use
case.

This change is part of the Connect API implementation:
https://www.notion.so/kurtosistech/Upgraded-Connectivity-ITERATION-1-86693f7143ad49d8958f9abc671b8f4e

## Is this change user facing?
YES

## References (if applicable):
Closes #1236
leeederek pushed a commit that referenced this issue Sep 11, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.82.22](0.82.21...0.82.22)
(2023-09-11)


### Features

* always pull latest image
([#1267](#1267))
([6706809](6706809))
* CLI run command option to disable user services port forwarding
([#1252](#1252))
([1c94378](1c94378)),
closes [#1236](#1236)
* retain logs for x weeks
([#1235](#1235))
([5f50c8c](5f50c8c))


### Bug Fixes

* inline upgrade warning
([#1254](#1254))
([33ef03a](33ef03a)),
closes [#1244](#1244)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant