fix: Reset the module global cache on every new interpretation to avoid using outdated modules #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbouv
force-pushed
the
gbouv/new-module-cache
branch
from
9f8622c
to
14a2ee2
Compare
h4ck3rk3y
pushed a commit
that referenced
this pull request
Sep 14, 2023
🤖 I have created a release *beep* *boop* --- ## [0.82.23](0.82.22...0.82.23) (2023-09-14) ### Features * folks can delete enclaves from the frontend ([#1250](#1250)) ([ee11b7c](ee11b7c)) * The current enclave plan is now persisted to the enclave DB every times the execution finishes ([#1280](#1280)) ([33d867e](33d867e)) ### Bug Fixes * follow logs ([#1298](#1298)) ([9b0bcb7](9b0bcb7)) * Reset the module global cache on every new interpretation to avoid using outdated modules ([#1291](#1291)) ([81c5462](81c5462)) * return after stream err ([#1301](#1301)) ([f40559b](f40559b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Using a single module cache lead to issues like this one b/c the interpreter was pulling the outdated cache.
Fixes #1226
Is this change user facing?
NO
References (if applicable):