fix: propagate failed img pull error to response line #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h4ck3rk3y
reviewed
Sep 14, 2023
.../server/api_container/server/startosis_engine/startosis_validator/docker_images_validator.go
Outdated
Show resolved
Hide resolved
h4ck3rk3y
approved these changes
Sep 14, 2023
h4ck3rk3y
reviewed
Sep 14, 2023
.../server/api_container/server/startosis_engine/startosis_validator/docker_images_validator.go
Show resolved
Hide resolved
h4ck3rk3y
approved these changes
Sep 14, 2023
.../server/api_container/server/startosis_engine/startosis_validator/docker_images_validator.go
Show resolved
Hide resolved
tedim52
pushed a commit
that referenced
this pull request
Sep 14, 2023
🤖 I have created a release *beep* *boop* --- ## [0.82.24](0.82.23...0.82.24) (2023-09-14) ### Bug Fixes * propagate failed img pull error to response line ([#1302](#1302)) ([9a4a928](9a4a928)) * revert always pull latest img ([#1306](#1306)) ([d4ef19e](d4ef19e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Prior to this change, errors causing failed image pulls were not being shown to the user.
In failed image pulls, user would see is
Failed fetching the required image '%v', make sure that the image exists and is public"- even if that image was public and existed.This PR propagates the image pull error all the way to the user to help them better debug the failed image pull.
Is this change user facing?
YES